Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back default button shadow token #791

Closed
wants to merge 4 commits into from
Closed

Add back default button shadow token #791

wants to merge 4 commits into from

Conversation

langermank
Copy link
Contributor

Reverts part of #733

screenshot of old PR

I was wrong.

@langermank langermank requested a review from a team as a code owner December 8, 2023 20:18
@langermank langermank requested review from a team, jonrohan and joshblack December 8, 2023 20:18
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 1f2a944

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023 •
edited
Loading

Variables changed 
No variables changed

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023 •
edited
Loading

Design Token Diff

/css/functional/themes/dark-colorblind.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-colorblind.css	2023-12-11 22:37:37.844529221 +0000
@@ -109,6 +109,7 @@
 --button-default-borderColor-active: #30363d;
 --button-default-borderColor-disabled: #161b22;
 --button-default-shadow-resting: 0px 0px 0px 0px #000000;
+  --button-default-shadow-inset: 0px 0px 0px 0px #000000;
 --button-primary-fgColor-rest: #ffffff;
 --button-primary-fgColor-disabled: #ffffff80;
 --button-primary-iconColor-rest: #ffffff;
@@ -529,6 +530,7 @@
   --button-default-borderColor-active: #30363d;
   --button-default-borderColor-disabled: #161b22;
   --button-default-shadow-resting: 0px 0px 0px 0px #000000;
+    --button-default-shadow-inset: 0px 0px 0px 0px #000000;
   --button-primary-fgColor-rest: #ffffff;
   --button-primary-fgColor-disabled: #ffffff80;
   --button-primary-iconColor-rest: #ffffff;

/css/functional/themes/dark-dimmed.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-dimmed.css	2023-12-11 22:37:37.216524141 +0000
@@ -109,6 +109,7 @@
 --button-default-borderColor-active: #444c56;
 --button-default-borderColor-disabled: #2d333b;
 --button-default-shadow-resting: 0px 0px 0px 0px #000000;
+  --button-default-shadow-inset: 0px 0px 0px 0px #000000;
 --button-primary-fgColor-rest: #cdd9e5;
 --button-primary-fgColor-disabled: #cdd9e580;
 --button-primary-iconColor-rest: #cdd9e5;
@@ -529,6 +530,7 @@
   --button-default-borderColor-active: #444c56;
   --button-default-borderColor-disabled: #2d333b;
   --button-default-shadow-resting: 0px 0px 0px 0px #000000;
+    --button-default-shadow-inset: 0px 0px 0px 0px #000000;
   --button-primary-fgColor-rest: #cdd9e5;
   --button-primary-fgColor-disabled: #cdd9e580;
   --button-primary-iconColor-rest: #cdd9e5;

/css/functional/themes/dark-high-contrast.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-high-contrast.css	2023-12-11 22:37:38.156531745 +0000
@@ -109,6 +109,7 @@
 --button-default-borderColor-active: #7a828e;
 --button-default-borderColor-disabled: #272b33;
 --button-default-shadow-resting: 0px 0px 0px 0px #000000;
+  --button-default-shadow-inset: 0px 0px 0px 0px #000000;
 --button-primary-fgColor-rest: #0a0c10;
 --button-primary-fgColor-disabled: #0a0c1080;
 --button-primary-iconColor-rest: #0a0c10;
@@ -529,6 +530,7 @@
   --button-default-borderColor-active: #7a828e;
   --button-default-borderColor-disabled: #272b33;
   --button-default-shadow-resting: 0px 0px 0px 0px #000000;
+    --button-default-shadow-inset: 0px 0px 0px 0px #000000;
   --button-primary-fgColor-rest: #0a0c10;
   --button-primary-fgColor-disabled: #0a0c1080;
   --button-primary-iconColor-rest: #0a0c10;

/css/functional/themes/dark-tritanopia.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-tritanopia.css	2023-12-11 22:37:37.536526730 +0000
@@ -109,6 +109,7 @@
 --button-default-borderColor-active: #30363d;
 --button-default-borderColor-disabled: #161b22;
 --button-default-shadow-resting: 0px 0px 0px 0px #000000;
+  --button-default-shadow-inset: 0px 0px 0px 0px #000000;
 --button-primary-fgColor-rest: #ffffff;
 --button-primary-fgColor-disabled: #ffffff80;
 --button-primary-iconColor-rest: #ffffff;
@@ -529,6 +530,7 @@
   --button-default-borderColor-active: #30363d;
   --button-default-borderColor-disabled: #161b22;
   --button-default-shadow-resting: 0px 0px 0px 0px #000000;
+    --button-default-shadow-inset: 0px 0px 0px 0px #000000;
   --button-primary-fgColor-rest: #ffffff;
   --button-primary-fgColor-disabled: #ffffff80;
   --button-primary-iconColor-rest: #ffffff;

/css/functional/themes/dark.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark.css	2023-12-11 22:37:36.900521585 +0000
@@ -109,6 +109,7 @@
 --button-default-borderColor-active: #30363d;
 --button-default-borderColor-disabled: #161b22;
 --button-default-shadow-resting: 0px 0px 0px 0px #000000;
+  --button-default-shadow-inset: 0px 0px 0px 0px #000000;
 --button-primary-fgColor-rest: #ffffff;
 --button-primary-fgColor-disabled: #ffffff80;
 --button-primary-iconColor-rest: #ffffff;
@@ -529,6 +530,7 @@
   --button-default-borderColor-active: #30363d;
   --button-default-borderColor-disabled: #161b22;
   --button-default-shadow-resting: 0px 0px 0px 0px #000000;
+    --button-default-shadow-inset: 0px 0px 0px 0px #000000;
   --button-primary-fgColor-rest: #ffffff;
   --button-primary-fgColor-disabled: #ffffff80;
   --button-primary-iconColor-rest: #ffffff;

/css/functional/themes/light-colorblind.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-colorblind.css	2023-12-11 22:37:36.144515470 +0000
@@ -109,6 +109,7 @@
 --button-default-borderColor-active: #d0d7de;
 --button-default-borderColor-disabled: #f6f8fa;
 --button-default-shadow-resting: 0px 1px 0px 0px #1f23280a;
+  --button-default-shadow-inset: inset 0px 1px 0px 0px #ffffff40;
 --button-primary-fgColor-rest: #ffffff;
 --button-primary-fgColor-disabled: #ffffffcc;
 --button-primary-iconColor-rest: #ffffffcc;
@@ -529,6 +530,7 @@
   --button-default-borderColor-active: #d0d7de;
   --button-default-borderColor-disabled: #f6f8fa;
   --button-default-shadow-resting: 0px 1px 0px 0px #1f23280a;
+    --button-default-shadow-inset: inset 0px 1px 0px 0px #ffffff40;
   --button-primary-fgColor-rest: #ffffff;
   --button-primary-fgColor-disabled: #ffffffcc;
   --button-primary-iconColor-rest: #ffffffcc;

/css/functional/themes/light-high-contrast.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-high-contrast.css	2023-12-11 22:37:36.484518220 +0000
@@ -109,6 +109,7 @@
 --button-default-borderColor-active: #20252c;
 --button-default-borderColor-disabled: #e7ecf0;
 --button-default-shadow-resting: 0px 1px 0px 0px #0104090a;
+  --button-default-shadow-inset: inset 0px 1px 0px 0px #ffffff40;
 --button-primary-fgColor-rest: #ffffff;
 --button-primary-fgColor-disabled: #ffffffcc;
 --button-primary-iconColor-rest: #ffffffcc;
@@ -529,6 +530,7 @@
   --button-default-borderColor-active: #20252c;
   --button-default-borderColor-disabled: #e7ecf0;
   --button-default-shadow-resting: 0px 1px 0px 0px #0104090a;
+    --button-default-shadow-inset: inset 0px 1px 0px 0px #ffffff40;
   --button-primary-fgColor-rest: #ffffff;
   --button-primary-fgColor-disabled: #ffffffcc;
   --button-primary-iconColor-rest: #ffffffcc;

/css/functional/themes/light-tritanopia.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-tritanopia.css	2023-12-11 22:37:35.740512202 +0000
@@ -109,6 +109,7 @@
 --button-default-borderColor-active: #d0d7de;
 --button-default-borderColor-disabled: #f6f8fa;
 --button-default-shadow-resting: 0px 1px 0px 0px #1f23280a;
+  --button-default-shadow-inset: inset 0px 1px 0px 0px #ffffff40;
 --button-primary-fgColor-rest: #ffffff;
 --button-primary-fgColor-disabled: #ffffffcc;
 --button-primary-iconColor-rest: #ffffffcc;
@@ -529,6 +530,7 @@
   --button-default-borderColor-active: #d0d7de;
   --button-default-borderColor-disabled: #f6f8fa;
   --button-default-shadow-resting: 0px 1px 0px 0px #1f23280a;
+    --button-default-shadow-inset: inset 0px 1px 0px 0px #ffffff40;
   --button-primary-fgColor-rest: #ffffff;
   --button-primary-fgColor-disabled: #ffffffcc;
   --button-primary-iconColor-rest: #ffffffcc;

/css/functional/themes/light.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light.css	2023-12-11 22:37:35.316508772 +0000
@@ -109,6 +109,7 @@
 --button-default-borderColor-active: #d0d7de;
 --button-default-borderColor-disabled: #f6f8fa;
 --button-default-shadow-resting: 0px 1px 0px 0px #1f23280a;
+  --button-default-shadow-inset: inset 0px 1px 0px 0px #ffffff40;
 --button-primary-fgColor-rest: #ffffff;
 --button-primary-fgColor-disabled: #ffffffcc;
 --button-primary-iconColor-rest: #ffffffcc;
@@ -529,6 +530,7 @@
   --button-default-borderColor-active: #d0d7de;
   --button-default-borderColor-disabled: #f6f8fa;
   --button-default-shadow-resting: 0px 1px 0px 0px #1f23280a;
+    --button-default-shadow-inset: inset 0px 1px 0px 0px #ffffff40;
   --button-primary-fgColor-rest: #ffffff;
   --button-primary-fgColor-disabled: #ffffffcc;
   --button-primary-iconColor-rest: #ffffffcc;

@github-actions github-actions bot temporarily deployed to storybook-preview December 8, 2023 20:20 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview December 8, 2023 20:20 Inactive
@lukasoppermann
Copy link
Contributor

@langermank there is no button on the screenshot? Why is this added back?

@langermank langermank added the update snapshots Update visual regression test snapshots label Dec 11, 2023
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Dec 11, 2023
@github-actions github-actions bot temporarily deployed to storybook-preview December 11, 2023 22:39 Inactive
@langermank langermank marked this pull request as draft December 11, 2023 22:44
@langermank
Copy link
Contributor Author

Closing this because I can't remember why I opened it 🤷

@langermank langermank closed this Apr 10, 2024
@lukasoppermann lukasoppermann deleted the fix-button-shadows branch April 18, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/css-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@langermank @lukasoppermann @joshblack