Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove motion tokens as they are not used and can easily be replaced by base tokens. #1186

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

lukasoppermann
Copy link
Contributor

Summary

The motion tokens from pattern and loading were not used, not even in the components they were built for, like skeleton and spinner.

They can also easily be replaced by our base tokens, namely duration-1000 and easing-linear.

Related react update: primer/react#5667

@lukasoppermann lukasoppermann self-assigned this Feb 7, 2025
@lukasoppermann lukasoppermann requested review from a team as code owners February 7, 2025 08:03
Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: 6827623

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Design Token Diff (CSS)

/css/primitives.css

+++ /home/runner/work/primitives/primitives/dist/css/primitives.css	2025-02-07 08:05:14.413498948 +0000
@@ -44,12 +44,6 @@
 --base-text-weight-semibold: 600;
}
:root {
-  --motion-loading-delay-default: var(--base-duration-1000); /* The amount of time to wait before showing a loading indicator or announcing a loading state to assistive technologies. */
-  --motion-skeletonLoader-shimmer-duration-scale: var(--base-duration-1000); /* The amount of times it takes the "shimmer" effect to go from the start (left) of the skeleton loader to the end (right) */
-  --motion-spinner-duration-rotation: var(--base-duration-1000); /* The amount of time it takes the "Spinner" loading indicator to make a full 360deg rotation */
-  --motion-spinner-easing-rotation: var(--base-easing-linear); /* The easing curve for the "Spinner" loading indicator rotation */
-}
-:root {
 --borderRadius-full: 624.9375rem; /* Use this border radius for pill shaped elements */
 --borderRadius-large: 0.75rem;
 --borderRadius-medium: 0.375rem;

@github-actions github-actions bot temporarily deployed to Preview (Storybook) February 7, 2025 08:05 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) February 7, 2025 08:06 Inactive
@lukasoppermann lukasoppermann merged commit 277ed66 into main Feb 7, 2025
27 checks passed
@lukasoppermann lukasoppermann deleted the move-motion-patterns branch February 7, 2025 08:15
@primer primer bot mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant