Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some light high contrast overrides into the respective token files #1181

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

lukasoppermann
Copy link
Contributor

Summary

List of notable changes:

What should reviewers focus on?

Steps to test:

@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label Feb 6, 2025
@lukasoppermann lukasoppermann self-assigned this Feb 6, 2025
@lukasoppermann lukasoppermann requested review from a team as code owners February 6, 2025 08:55
@lukasoppermann lukasoppermann changed the title Light hc separate tokens Add some light high contrast overrides into the respective token files Feb 6, 2025
Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: 2519c80

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Design Token Diff (StyleLint)

The message is too long to be displayed here. For more details, please check the job summary.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Design Token Diff (Figma)

/figma/themes/light-high-contrast.json

+++ /home/runner/work/primitives/primitives/dist/figma/themes/light-high-contrast.json	2025-02-06 09:54:16.935404279 +0000
@@ -377,6 +377,133 @@
   "scopes": ["TEXT_FILL", "SHAPE_FILL"]
 },
 {
+    "name": "button/primary/bgColor/rest",
+    "value": {
+      "r": 0.0196078431372549,
+      "g": 0.36470588235294116,
+      "b": 0.12549019607843137,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/button/primary/bgColor/rest",
+    "reference": "base/color/light-high-contrast/base/color/green/5",
+    "collection": "mode",
+    "mode": "light high contrast",
+    "group": "component (internal)",
+    "scopes": ["FRAME_FILL", "SHAPE_FILL"]
+  },
+  {
+    "name": "button/primary/bgColor/hover",
+    "value": {
+      "r": 0.01568627450980392,
+      "g": 0.3411764705882353,
+      "b": 0.11764705882352941,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/button/primary/bgColor/hover",
+    "collection": "mode",
+    "mode": "light high contrast",
+    "group": "component (internal)",
+    "scopes": ["FRAME_FILL", "SHAPE_FILL"]
+  },
+  {
+    "name": "button/primary/bgColor/active",
+    "value": {
+      "r": 0.011764705882352941,
+      "g": 0.3137254901960784,
+      "b": 0.10588235294117647,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/button/primary/bgColor/active",
+    "collection": "mode",
+    "mode": "light high contrast",
+    "group": "component (internal)",
+    "scopes": ["FRAME_FILL", "SHAPE_FILL"]
+  },
+  {
+    "name": "button/primary/bgColor/disabled",
+    "value": {
+      "r": 0.5215686274509804,
+      "g": 0.796078431372549,
+      "b": 0.592156862745098,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/button/primary/bgColor/disabled",
+    "collection": "mode",
+    "mode": "light high contrast",
+    "group": "component (internal)",
+    "scopes": ["FRAME_FILL", "SHAPE_FILL"]
+  },
+  {
+    "name": "button/primary/borderColor/rest",
+    "value": {
+      "r": 0.00392156862745098,
+      "g": 0.23921568627450981,
+      "b": 0.0784313725490196,
+      "a": 1
+    },
+    "type": "COLOR",
+    "alpha": 1,
+    "refId": "mode/button/primary/borderColor/rest",
+    "reference": "base/color/light-high-contrast/base/color/green/7",
+    "collection": "mode",
+    "mode": "light high contrast",
+    "group": "component (internal)",
+    "scopes": ["STROKE_COLOR"]
+  },
+  {
+    "name": "button/primary/borderColor/hover",
+    "value": {
+      "r": 0.00392156862745098,
+      "g": 0.23921568627450981,
+      "b": 0.0784313725490196,
+      "a": 1
+    },
+    "type": "COLOR",
+    "alpha": 1,
+    "refId": "mode/button/primary/borderColor/hover",
+    "reference": "base/color/light-high-contrast/base/color/green/7",
+    "collection": "mode",
+    "mode": "light high contrast",
+    "group": "component (internal)",
+    "scopes": ["STROKE_COLOR"]
+  },
+  {
+    "name": "button/primary/borderColor/active",
+    "value": {
+      "r": 0.00392156862745098,
+      "g": 0.23921568627450981,
+      "b": 0.0784313725490196,
+      "a": 1
+    },
+    "type": "COLOR",
+    "alpha": 1,
+    "refId": "mode/button/primary/borderColor/active",
+    "reference": "base/color/light-high-contrast/base/color/green/7",
+    "collection": "mode",
+    "mode": "light high contrast",
+    "group": "component (internal)",
+    "scopes": ["STROKE_COLOR"]
+  },
+  {
+    "name": "button/primary/borderColor/disabled",
+    "value": {
+      "r": 0.5215686274509804,
+      "g": 0.796078431372549,
+      "b": 0.592156862745098,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/button/primary/borderColor/disabled",
+    "collection": "mode",
+    "mode": "light high contrast",
+    "group": "component (internal)",
+    "scopes": ["STROKE_COLOR"]
+  },
+  {
   "name": "button/outline/shadow/selected/offsetX",
   "value": 0,
   "type": "FLOAT",
@@ -524,6 +651,21 @@
   "scopes": ["FRAME_FILL", "SHAPE_FILL"]
 },
 {
+    "name": "button/outline/bgColor/active",
+    "value": {
+      "r": 0.011764705882352941,
+      "g": 0.24705882352941178,
+      "b": 0.615686274509804,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/button/outline/bgColor/active",
+    "collection": "mode",
+    "mode": "light high contrast",
+    "group": "component (internal)",
+    "scopes": ["FRAME_FILL", "SHAPE_FILL"]
+  },
+  {
   "name": "button/outline/bgColor/disabled",
   "value": {
     "r": 0.8784313725490196,
@@ -549,7 +691,7 @@
   },
   "type": "COLOR",
   "refId": "mode/button/outline/borderColor/hover",
-    "reference": "button/primary/borderColor/hover",
+    "reference": "mode/button/primary/borderColor/hover",
   "collection": "mode",
   "mode": "light high contrast",
   "group": "component (internal)",
@@ -751,6 +893,21 @@
   "scopes": ["FRAME_FILL", "SHAPE_FILL"]
 },
 {
+    "name": "button/danger/bgColor/active",
+    "value": {
+      "r": 0.4549019607843137,
+      "g": 0.01568627450980392,
+      "b": 0.10196078431372549,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/button/danger/bgColor/active",
+    "collection": "mode",
+    "mode": "light high contrast",
+    "group": "component (internal)",
+    "scopes": ["FRAME_FILL", "SHAPE_FILL"]
+  },
+  {
   "name": "button/danger/bgColor/disabled",
   "value": {
     "r": 0.8784313725490196,
@@ -792,7 +949,7 @@
   },
   "type": "COLOR",
   "refId": "mode/button/danger/borderColor/hover",
-    "reference": "button/primary/borderColor/rest",
+    "reference": "mode/button/primary/borderColor/rest",
   "collection": "mode",
   "mode": "light high contrast",
   "group": "component (internal)",
@@ -831,6 +988,22 @@
   "scopes": ["TEXT_FILL", "SHAPE_FILL"]
 },
 {
+    "name": "button/invisible/fgColor/hover",
+    "value": {
+      "r": 0.2235294117647059,
+      "g": 0.24705882352941178,
+      "b": 0.27450980392156865,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/button/invisible/fgColor/hover",
+    "reference": "base/color/light/base/color/neutral/11",
+    "collection": "mode",
+    "mode": "light high contrast",
+    "group": "component (internal)",
+    "scopes": ["TEXT_FILL", "SHAPE_FILL"]
+  },
+  {
   "name": "button/invisible/fgColor/active",
   "value": {
     "r": 0.1450980392156863,
@@ -879,6 +1052,22 @@
   "scopes": ["TEXT_FILL", "SHAPE_FILL"]
 },
 {
+    "name": "button/invisible/iconColor/hover",
+    "value": {
+      "r": 0.2235294117647059,
+      "g": 0.24705882352941178,
+      "b": 0.27450980392156865,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/button/invisible/iconColor/hover",
+    "reference": "base/color/light/base/color/neutral/11",
+    "collection": "mode",
+    "mode": "light high contrast",
+    "group": "component (internal)",
+    "scopes": ["TEXT_FILL", "SHAPE_FILL"]
+  },
+  {
   "name": "button/invisible/iconColor/disabled",
   "value": {
     "r": 0.34901960784313724,
@@ -1023,6 +1212,22 @@
   "scopes": ["TEXT_FILL", "SHAPE_FILL"]
 },
 {
+    "name": "button/inactive/bgColor",
+    "value": {
+      "r": 0.8784313725490196,
+      "g": 0.9019607843137255,
+      "b": 0.9215686274509803,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/button/inactive/bgColor",
+    "reference": "mode/control/bgColor/rest",
+    "collection": "mode",
+    "mode": "light high contrast",
+    "group": "component (internal)",
+    "scopes": ["FRAME_FILL", "SHAPE_FILL"]
+  },
+  {
   "name": "button/star/iconColor",
   "value": {
     "r": 0.8352941176470589,
@@ -1887,6 +2092,22 @@
   "scopes": ["FRAME_FILL", "SHAPE_FILL"]
 },
 {
+    "name": "buttonCounter/default/bgColor/rest",
+    "value": {
+      "r": 0.7843137254901961,
+      "g": 0.8196078431372549,
+      "b": 0.8549019607843137,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/buttonCounter/default/bgColor/rest",
+    "reference": "base/color/light/base/color/neutral/7",
+    "collection": "mode",
+    "mode": "light high contrast",
+    "group": "component (internal)",
+    "scopes": ["FRAME_FILL", "SHAPE_FILL"]
+  },
+  {
   "name": "buttonCounter/invisible/bgColor/rest",
   "value": {
     "r": 0.8784313725490196,
@@ -2071,6 +2292,21 @@
   "scopes": ["FRAME_FILL", "SHAPE_FILL"]
 },
 {
+    "name": "buttonCounter/danger/fgColor/rest",
+    "value": {
+      "r": 0.596078431372549,
+      "g": 0.054901960784313725,
+      "b": 0.11764705882352941,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/buttonCounter/danger/fgColor/rest",
+    "collection": "mode",
+    "mode": "light high contrast",
+    "group": "component (internal)",
+    "scopes": ["TEXT_FILL", "SHAPE_FILL"]
+  },
+  {
   "name": "buttonCounter/danger/fgColor/hover",
   "value": {
     "r": 1,
@@ -3150,6 +3386,22 @@
   "scopes": ["TEXT_FILL", "SHAPE_FILL"]
 },
 {
+    "name": "header/borderColor/divider",
+    "value": {
+      "r": 0.7843137254901961,
+      "g": 0.8196078431372549,
+      "b": 0.8549019607843137,
+      "a": 1
+    },
+    "type": "COLOR",
+    "refId": "mode/header/borderColor/divider",
+    "reference": "base/color/light/base/color/neutral/7",
+    "collection": "mode",
+    "mode": "light high contrast",
+    "group": "component (internal)",
+    "scopes": ["STROKE_COLOR"]
+  },
+  {
   "name": "headerSearch/bgColor",
   "value": {
     "r": 0.1450980392156863,

@lukasoppermann lukasoppermann force-pushed the lightHC-separate-tokens branch from ca9b2c9 to 2519c80 Compare February 6, 2025 09:53
@github-actions github-actions bot temporarily deployed to Preview (Storybook) February 6, 2025 09:55 Inactive
@lukasoppermann lukasoppermann merged commit 57ae2c5 into main Feb 6, 2025
27 checks passed
@lukasoppermann lukasoppermann deleted the lightHC-separate-tokens branch February 6, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant