Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inline octicon in branch name example #886

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

colebemis
Copy link
Contributor

This pull request replaces the usage of StyledOcticon with an inline SVG in a branch name code example. This inline SVG approach is what we've been using to display octicons in live code examples until Doctocat supports erb helpers.

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Sep 6, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-colebemis-patch-1.primer.now.sh

@simurai simurai mentioned this pull request Sep 21, 2019
6 tasks
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants