Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Colorable url #867

Merged
merged 2 commits into from
Aug 23, 2019
Merged

Update Colorable url #867

merged 2 commits into from
Aug 23, 2019

Conversation

kiendang
Copy link
Contributor

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Aug 16, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-fork-kiendang-patch-1.primer.now.sh

@emilybrick
Copy link
Contributor

Awesome – thanks for catching @kiendang!

@shawnbot shawnbot mentioned this pull request Aug 22, 2019
Merged
10 tasks
@shawnbot shawnbot changed the base branch from master to release-12.6.1 August 22, 2019 18:23
@shawnbot
Copy link
Contributor

Hey @kiendang, would you mind rebasing this branch in your fork with master? #851 moved the docs you've edited around, hence the merge conflict.

simurai
simurai approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiendang Thanks for updating the URL. 👍 ❤️

Merged in master to resolve the merge conflict. Let's merge it into 12.6.1. 🚢

@simurai simurai merged commit 9576243 into primer:release-12.6.1 Aug 23, 2019
@kiendang
Copy link
Contributor Author

Thanks a lot @simurai for taking care of the conflict.

@kiendang kiendang deleted the patch-1 branch August 23, 2019 08:27
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
This was referenced Dec 14, 2022
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Dec 21, 2022
Open
This was referenced Jan 6, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilybrick emilybrick emilybrick approved these changes

@simurai simurai simurai approved these changes

Assignees
No one assigned
Labels
patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiendang @emilybrick @shawnbot @simurai