Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding user details to storybook publish script #530

Merged
merged 3 commits into from
Oct 17, 2018

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Jul 3, 2018

The auto storybook script publishes and doesn't have a user attached to it, so we get commits that look like this:

image

primer/storybook@ef149d7

This pull adds user info so that @primer-css will be the committer.

@primer/design-systems

@shawnbot shawnbot changed the base branch from master to release-10.7.1 July 3, 2018 19:28
@shawnbot
Copy link
Contributor

shawnbot commented Jul 3, 2018

@jonrohan I queued this up for 10.7.1 in #527, but feel free to move it to #523 (10.8.0) if you'd like. Looks like we'll need to merge master into that branch to shrink the diff.

@shawnbot shawnbot changed the base branch from release-10.7.1 to release-10.9.0 October 5, 2018 23:38
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's ship this in v10.9.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants