Add utility classes for <details> #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been confused by the "expanded" qualifier in the past. I wonder if there's a better word to describe it, like "modal"? |
I agree the name can be better. This needs to be more generic than "modal" though since it's also used on our dropdowns too. 🤔 |
|
The dropdowns are modal, though, in the sense that you have to click out of them before you can do anything else — right? Just for argument's sake:
I think |
|
I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
<details>utility classes we use on dotcom to Primer. Added docs & stories. Hopefully I did them correctly!/cc @primer/ds-core