Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.6.0 Release Tracking PR #492

Merged
merged 83 commits into from
Jun 14, 2018
Merged
Show file tree
Hide file tree
Changes from 78 commits
Commits
Show all changes
83 commits
Select commit Hold shift + click to select a range
9f731dc
nest primer-module-build in tools/primer-module-build
shawnbot Apr 26, 2018
1657aa0
move stuff again (with filter-branch)
shawnbot Apr 26, 2018
90ebafd
Merge branch 'monorepo' of ../primer-module-build into import-primer-…
shawnbot Apr 26, 2018
8683a19
nix primer-module-build/LICENSE
shawnbot Apr 26, 2018
5b848a6
uninstall primer-module-build; upgrade node-sass
shawnbot Apr 26, 2018
a39a52a
re-add license, eslint config
shawnbot Apr 27, 2018
7dc2250
upgrade node-sass; remove hoisted devDependencies
shawnbot Apr 27, 2018
b4b7ab2
update build() call to use the promise interface
shawnbot Apr 27, 2018
77e860d
re-add primer-module-build tests
shawnbot Apr 27, 2018
bbb3dc7
fix up run-script calls; add node-sass-import
shawnbot Apr 27, 2018
59bf677
refactor primer-module-build: async + node module resolution
shawnbot Apr 27, 2018
9919c00
remove stylelint-config-primer from top-level package.json
shawnbot Apr 27, 2018
5455919
use npx; claim tool dependencies as "*"
shawnbot Apr 27, 2018
378b8a1
use file: dependencies for primer tools
shawnbot Apr 27, 2018
ef1596f
update to cssstats@3.2.0
shawnbot Apr 30, 2018
719c372
tweak sass option handling; move Promise handling to cli.js
shawnbot Apr 30, 2018
5c32374
lint cleanup
shawnbot Apr 30, 2018
8781324
add pify
shawnbot Apr 30, 2018
19e1065
fix absolute paths
shawnbot Apr 30, 2018
6306547
test more things; stub out fixtures dir
shawnbot Apr 30, 2018
bf17f06
Merge branch 'dev' into import-primer-module-build
shawnbot Apr 30, 2018
5a0947f
moar tests
shawnbot Apr 30, 2018
81e26ec
moar tests
shawnbot Apr 30, 2018
a39ec24
add babel-core dev dependency for Storybook
shawnbot May 2, 2018
741e1af
Merge branch 'dev' into import-primer-module-build
shawnbot May 3, 2018
5edf32a
first pass at scoreboard script
shawnbot May 3, 2018
27b96ac
add minimatch
shawnbot May 3, 2018
ab9cc3e
pass args through to ava from script/test-docs
shawnbot May 3, 2018
4ba2368
refactor docs test: more async, one test per class
shawnbot May 3, 2018
c2226b6
scoreboard reorg; better docs test output parsing
shawnbot May 3, 2018
77f987f
add primer.class_whitelist for doc tests
shawnbot May 3, 2018
c4b984d
add FIXME comment to deprecate .warning in primer-alerts
shawnbot May 3, 2018
02a2370
add test script to run the scoreboard
shawnbot May 3, 2018
200025c
generate the scoreboard before running tests
shawnbot May 3, 2018
bd4a414
Merge pull request #479 from primer/scoreboard
shawnbot May 9, 2018
138c49f
Merge branch 'dev' into import-primer-module-build
shawnbot May 9, 2018
d5aeca7
add meta/* to lerna packages
shawnbot May 9, 2018
370fcd5
reconcile execa version w/scorecard
shawnbot May 9, 2018
849e903
add name to meta/scorecard/package.json
shawnbot May 9, 2018
730bd78
nix explicit scorecard test from travis script
shawnbot May 9, 2018
ff07c6d
remove unused import
shawnbot May 9, 2018
90964d2
Merge pull request #475 from primer/import-primer-module-build
shawnbot May 9, 2018
5bd346b
don't ignore npm lockfiles
shawnbot May 11, 2018
f0f2f26
always save new dependencies, and use exact version
shawnbot May 11, 2018
6e84d94
update all storybook deps to 3.4.3
shawnbot May 11, 2018
ce131f3
new npm@5 lockfile
shawnbot May 11, 2018
1b3bf46
let's all use Node v8, mmkay?
shawnbot May 11, 2018
97dbc07
update npm lockfile
shawnbot May 11, 2018
81cf30f
Merge branch 'master' into dev
jonrohan May 11, 2018
993cb32
update all package-lock.json lockfiles
shawnbot May 11, 2018
a221750
update package-lock.json after bootstrap
shawnbot May 11, 2018
1a0637f
Merge branch 'dev' into fix-storybook
shawnbot May 11, 2018
70dc7d7
add releasing docs
May 11, 2018
e6bd185
add link to README
May 11, 2018
9024c20
minor edits
May 11, 2018
722a7a5
change link anchor in readme
May 14, 2018
3c49f4f
changes to updating the styleguide
May 14, 2018
4d671ff
add staff only to releasing documentation
May 14, 2018
450c58c
a few more tweaks to releasing docs
May 14, 2018
76ab274
Added `backface-visibility` to .hover-grow
brandonrosage May 18, 2018
1ba4158
update version to 10.6.0
May 18, 2018
ac14cc9
Add utility classes for <details>
muan May 23, 2018
d565da6
. details-expanded -> .details-overlay
muan Jun 1, 2018
626af21
.details-expanded -> .details-overlay
muan Jun 1, 2018
e97cc01
.details-expanded -> .details-overlay
muan Jun 1, 2018
ba1b029
Merge pull request #495 from primer/muan/details-el
jonrohan Jun 13, 2018
62922ac
Merge branch 'import-primer-module-build' into release-10.6.0
jonrohan Jun 13, 2018
7cc1b27
Merge branch 'fix-storybook' into release-10.6.0
jonrohan Jun 13, 2018
d6ed360
Merge pull request #491 from primer/hover-grow-bug
jonrohan Jun 13, 2018
cc224d0
Merge pull request #490 from primer/task/add-release-docs
jonrohan Jun 13, 2018
bfa0986
trying something
jonrohan Jun 13, 2018
31c9f33
Revert back to 10.6.0
jonrohan Jun 13, 2018
e57066f
Removing meta from lerna
jonrohan Jun 13, 2018
87e59a9
Changelog :pencil:
jonrohan Jun 13, 2018
0f0fc32
Publish
jonrohan Jun 13, 2018
a246fe9
Update package-lock.json
jonrohan Jun 13, 2018
aacc037
Update package-lock.json
jonrohan Jun 13, 2018
36479bb
removing package-lock
jonrohan Jun 13, 2018
c73eda1
move to dev deps
jonrohan Jun 13, 2018
e69ce06
Adding package-lock.json back
jonrohan Jun 13, 2018
1d5553d
Adding package-lock.json back
jonrohan Jun 13, 2018
6a0de23
Versions here?
jonrohan Jun 13, 2018
9d12116
Versions
jonrohan Jun 13, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
.DS_Store
.sass-cache
node_modules
**/package-lock.json
*.log
build
_site
*.lerna_backup
.changelog
**/package-lock.json
2 changes: 2 additions & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
save=true
save-exact=true
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
8
19 changes: 19 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,22 @@
# 10.6.0

#### :bug: Bug Fix
* [#491](https://github.com/primer/primer/pull/491) Add `backface-visibility` to `.hover-grow`. ([@brandonrosage](https://github.com/brandonrosage))

#### :memo: Documentation
* [#490](https://github.com/primer/primer/pull/490) Add release documentation. ([@emplums](https://github.com/emplums))

#### :house: Internal
* [#475](https://github.com/primer/primer/pull/475) Import primer-module-build to the monorepo. ([@shawnbot](https://github.com/shawnbot))
* [#479](https://github.com/primer/primer/pull/479) Add "scoreboard" test suite. ([@shawnbot](https://github.com/shawnbot))

#### Committers: 4
- Brandon Rosage ([brandonrosage](https://github.com/brandonrosage))
- Emily ([emplums](https://github.com/emplums))
- Shawn Allen ([shawnbot](https://github.com/shawnbot))
- [muan](https://github.com/muan)


# 10.5.0

#### :rocket: Enhancement
Expand Down
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ For a compiled **CSS** version of this module, an npm script is included that wi
$ npm run build
```

## Releasing (Staff only)

You can find docs about our release process in [RELEASING.md](./RELEASING.md).

## Documentation

You can read more about primer in the [docs][docs].
Expand Down
68 changes: 68 additions & 0 deletions RELEASING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
## Releasing a new Primer version 🎉


### In `primer/primer`:

1. Create a new release branch from `dev` and name it `release-<version>`.

(CI will publish a release candidate version to npm for branches prefixed with `release`. These version numbers have a `rc.<number>` suffix on them)

2. Go through the tracking issue and make sure everything that should be merged in is merged in.

3. Once your builds finish, click on the details links for the continuous-integration/travis-ci/push build. Expand the `Deploying application` output and you should be able to find an outputted change log here. Copy this and update the [CHANGELOG.md](https://github.com/primer/primer/blob/master/CHANGELOG.md) file.

4. Run the version bump in your terminal: `npm run bump`.

5. Test your changes with the latest release candidate version in the appropriate places (styleguide, storybook, github/github).

6. Once the release PR is approved and you've done necessary testing, merge to `master`. This will trigger a publish to npm.


### In `github/github`:

1. Create a new branch

2. Update the primer version in your terminal `npm install primer@<version>`.

3. Update `stylelint-config-primer` in your terminal to the appropriate version `npm install stylelint-config-primer@latest`.

4. If you need to make changes to github/github due to the Primer release, make a separate branch. When ready, merge that branch into your release branch.

5. Add reviewers.

6. Check that every deleted vendor file has an accompanying updated vendor file and that the version numbers look correct.

7. Test on review-lab.

8. When ready, merge! 🎉


## Other items that need to be done after publishing Primer

#### Update the Style Guide

1. In [github/styleguide](https://github.com/github/styleguide), update `primer` to your newly released version in your terminal:

`npm install primer@latest`

2. Then run: `script/update-primer-docs`.

3. Commit changes, make PR, get it approved, merge! 🚀

#### Update [primer.github.io](primer.github.io)

1. Edit [index.html](https://github.com/primer/primer.github.io/blob/master/index.html) to include the latest version.

#### Update Storybook

1. Pull the latest from master on primer/primer (after merging in release branch).

2. Run `npm run publish-storybook`.

#### Publish release tag

1. Create a new release tag [here](https://github.com/primer/primer/releases/new).

2. Copy the changes from the [CHANGELOG](https://github.com/primer/primer/blob/master/CHANGELOG.md) and paste it into the release notes.

3. Publish 🎉
96 changes: 96 additions & 0 deletions meta/scoreboard/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
const {basename, join, resolve} = require('path')
const PromiseQueue = require('p-queue')
const execa = require('execa')
const globby = require('globby')
const rootDir = resolve(__dirname, '../..')
const lernaConfig = require(join(rootDir, 'lerna.json'))
const modulesDir = join(rootDir, 'modules')
require('console.table')

const unique = list => Array.from(new Set(list)).sort()

const matchAll = (pattern, text) => {
const matches = []
let match
while (match = pattern.exec(text)) {
matches.push(match)
}
return matches
}

const checks = {
'has stories': (module, key) => {
return globby(join(module.path, '**/stories.js'))
.then(files => ({
[key]: files.length > 0 ? 'yes' : 'no'
}))
},
'docs test': (module, key) => {
return execa(join(rootDir, 'script/test-docs'), {
cwd: module.path
})
.then(result => ({[key]: 'pass'}))
.catch(({stderr}) => {
const pattern = /("\.[-\w]+") is not documented/g
const matches = matchAll(pattern, stderr)
.map(match => match[1])
let missing = matches ? Array.from(matches) : []
const max = 5
if (missing.length > max) {
const more = missing.length - max
missing = missing.slice(0, max).concat(`and ${more} more...`)
}
return {
[key]: 'FAIL',
'missing docs': unique(missing).join(', ')
}
})
}
}

const args = process.argv.slice(2)

const modules = args.length
? Promise.resolve(args)
: globby(join(modulesDir, 'primer-*'))

modules
.then(moduleDirs => {
console.log('Found %d module directories', moduleDirs.length)
return moduleDirs
.map(path => ({
path,
name: basename(path),
pkg: require(join(path, 'package.json'))
}))
.filter(({pkg}) => pkg.primer.module_type !== 'meta')
})
.then(modules => {
console.log('Filtered to %d modules (excluding meta-packages)', modules.length)

const queue = new PromiseQueue({concurrency: 3})

for (const module of modules) {
module.checks = {}
for (const [name, check] of Object.entries(checks)) {
queue.add(() => {
// console.warn(`? check: ${module.name} ${name}`)
return check(module, name)
.then(result => {
Object.assign(module.checks, result)
})
})
}
}

console.warn(`Running ${queue.size} checks...`)
return queue.onIdle().then(() => modules)
})
.then(modules => {
console.warn('ran tests on %d modules', modules.length)
const rows = modules.map(({name, checks}) => {
return Object.assign({'package': name}, checks)
})
console.table(rows)
})

13 changes: 13 additions & 0 deletions meta/scoreboard/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"private": true,
"name": "primer-scorecard",
"scripts": {
"test": "node index.js"
},
"devDependencies": {
"console.table": "^0.10.0",
"execa": "^0.10.0",
"globby": "^6.1.0",
"p-queue": "^2.4.2"
}
}
1 change: 1 addition & 0 deletions modules/primer-alerts/lib/flash.scss
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
border-radius: 0;
}

// FIXME deprecate this
.warning {
padding: $em-spacer-5;
margin-bottom: 0.8em;
Expand Down
9 changes: 6 additions & 3 deletions modules/primer-alerts/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "1.5.6",
"version": "1.5.7",
"name": "primer-alerts",
"description": "Flash messages, or alerts, inform users of successful or pending actions.",
"homepage": "http://primer.github.io/",
Expand All @@ -10,7 +10,10 @@
"main": "build/index.js",
"primer": {
"category": "product",
"module_type": "components"
"module_type": "components",
"class_whitelist": [
"warning"
]
},
"files": [
"index.scss",
Expand All @@ -28,7 +31,7 @@
"test": "../../script/npm-run-all build lint"
},
"dependencies": {
"primer-support": "4.5.3"
"primer-support": "4.5.4"
},
"keywords": [
"alerts",
Expand Down
4 changes: 2 additions & 2 deletions modules/primer-avatars/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "1.5.3",
"version": "1.5.4",
"name": "primer-avatars",
"description": "Basic styles for user profile avatars.",
"homepage": "http://primer.github.io/",
Expand Down Expand Up @@ -28,7 +28,7 @@
"test": "../../script/npm-run-all build lint"
},
"dependencies": {
"primer-support": "4.5.3"
"primer-support": "4.5.4"
},
"keywords": [
"avatars",
Expand Down
10 changes: 7 additions & 3 deletions modules/primer-base/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "1.7.1",
"version": "1.7.2",
"name": "primer-base",
"description": "CSS to reset the browsers default styles",
"homepage": "http://primer.github.io/",
Expand All @@ -10,7 +10,11 @@
"main": "build/index.js",
"primer": {
"category": "core",
"module_type": "support"
"module_type": "support",
"class_whitelist": [
"octicon",
"rule"
]
},
"files": [
"index.scss",
Expand All @@ -28,7 +32,7 @@
"test": "../../script/npm-run-all build lint"
},
"dependencies": {
"primer-support": "4.5.3"
"primer-support": "4.5.4"
},
"keywords": [
"primer",
Expand Down
4 changes: 2 additions & 2 deletions modules/primer-blankslate/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "1.4.6",
"version": "1.4.7",
"name": "primer-blankslate",
"description": "Blankslates are for when there is a lack of content within a page or section.",
"homepage": "http://primer.github.io/",
Expand Down Expand Up @@ -28,7 +28,7 @@
"test": "../../script/npm-run-all build lint"
},
"dependencies": {
"primer-support": "4.5.3"
"primer-support": "4.5.4"
},
"keywords": [
"primer",
Expand Down
4 changes: 2 additions & 2 deletions modules/primer-box/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "2.5.6",
"version": "2.5.7",
"name": "primer-box",
"description": "A module for creating rounded-corner boxes with options for headers, lists, and footers.",
"homepage": "http://primer.github.io/",
Expand Down Expand Up @@ -28,7 +28,7 @@
"test": "../../script/npm-run-all build lint"
},
"dependencies": {
"primer-support": "4.5.3"
"primer-support": "4.5.4"
},
"keywords": [
"primer",
Expand Down
4 changes: 2 additions & 2 deletions modules/primer-branch-name/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "1.0.4",
"version": "1.0.5",
"name": "primer-branch-name",
"description": "A nice, consistent way to display branch names.",
"homepage": "http://primer.github.io/",
Expand Down Expand Up @@ -29,7 +29,7 @@
"test": "../../script/npm-run-all build lint test-docs"
},
"dependencies": {
"primer-support": "4.5.3"
"primer-support": "4.5.4"
},
"keywords": [
"github",
Expand Down
4 changes: 2 additions & 2 deletions modules/primer-breadcrumb/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "1.5.2",
"version": "1.5.3",
"name": "primer-breadcrumb",
"description": "Breadcrumb navigation for pages with parents / grandparents.",
"homepage": "http://primer.github.io/",
Expand Down Expand Up @@ -29,7 +29,7 @@
"test": "../../script/npm-run-all build lint test-docs"
},
"dependencies": {
"primer-support": "4.5.3"
"primer-support": "4.5.4"
},
"keywords": [
"breadcrumb",
Expand Down
4 changes: 2 additions & 2 deletions modules/primer-buttons/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "2.5.4",
"version": "2.5.5",
"name": "primer-buttons",
"description": "A collection of buttons used for primary and secondary actions.",
"homepage": "http://primer.github.io/",
Expand Down Expand Up @@ -28,7 +28,7 @@
"test": "../../script/npm-run-all build lint"
},
"dependencies": {
"primer-support": "4.5.3"
"primer-support": "4.5.4"
},
"keywords": [
"primer",
Expand Down
Loading