Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release documentation #490

Merged
merged 7 commits into from
Jun 13, 2018
Merged

Add release documentation #490

merged 7 commits into from
Jun 13, 2018

Conversation

emplums
Copy link
Contributor

@emplums emplums commented May 11, 2018

Adds some documentation around shipping a Primer release 🎉

Would love input if I've missed anything, or if anything sounds confusing! 💞

/cc @primer/ds-core

README.md Outdated
@@ -61,6 +61,10 @@ For a compiled **CSS** version of this module, an npm script is included that wi
$ npm run build
```

## Releasing
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add something indicating releasing is only something Staff can do, or is that obvious enough?

README.md Outdated
@@ -61,6 +61,10 @@ For a compiled **CSS** version of this module, an npm script is included that wi
$ npm run build
```

## Releasing

You can find docs about our release process [here](./RELEASING.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the "here" link text to "in RELEASING.md"?

RELEASING.md Outdated

#### Update the Style Guide

1. In [github/styleguide](https://github.com/github/styleguide), Update `primer` to your newly released version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we be more specific here, i.e.

npm install primer@latest

@emplums
Copy link
Contributor Author

emplums commented May 14, 2018

@broccolini what do you think about keeping the release docs in this repo? It might be kind of interesting for people outside Github to see how our release process works and it feels nice to have all the docs in one place 🤔

RELEASING.md Outdated

2. In your command line run: `script/update-primer-docs`.
`npm install primer@latest`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This renders a little funkily:

image

For consistency, it's probably best to just inline it rather than turning it into a full-on code block with triple backticks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh weird! It's only using single backticks but maybe the spacing is off 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it's un-indented because it's on a new line and not indented 4 spaces.

@emplums emplums mentioned this pull request Jun 11, 2018
15 tasks
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start to the docs 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants