Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styleguide Polish #481

Merged
merged 21 commits into from
May 8, 2018
Merged

Styleguide Polish #481

merged 21 commits into from
May 8, 2018

Conversation

emplums
Copy link
Contributor

@emplums emplums commented May 4, 2018

Fixes all the internal links 🎉

/cc @primer/ds-core

@emplums emplums requested a review from broccolini May 7, 2018 17:39
@@ -115,7 +115,7 @@ In practice, your columns will look like the example below.

##### Centered

Columns can be [centered](/utilities/#centering-content) by adding `.centered` to the `.column` class.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this link since it seemed like we don't have a section about centering content anymore? cc @broccolini

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it could go to /objects/layout/, but that's deprecated, so...? 😬

@emplums emplums added 💓collab a vibrant hub of collaboration Tag: Documentation labels May 7, 2018
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jonrohan jonrohan changed the base branch from master to release-10.5.0 May 8, 2018 21:47
@jonrohan jonrohan merged commit 87fbb5d into release-10.5.0 May 8, 2018
@jonrohan jonrohan deleted the task/styleguide-polish branch May 8, 2018 21:48
@shawnbot shawnbot mentioned this pull request May 8, 2018
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💓collab a vibrant hub of collaboration Tag: Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants