Update dead links in CONTRIBUTING.md #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus, I removed a blank space
|
|
This PR is ready for review 🎉 |
jonrohan
approved these changes
Feb 28, 2018
There was a problem hiding this comment.
Thanks for this contribution @agisilaos! I was pleasantly surprised to see help from the community in my inbox this morning. ❤️
I'll be pushing this out in the next release #451
.github/CONTRIBUTING.md
Outdated
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| Hi there! We're thrilled that you'd like to contribute to this project. Your help is essential for keeping it great. | |||
|
|
|||
| Before you do, would you mind reading [this license agreement](CLA.md)? If you open a PR, we'll assume you agree to it. If you have any hesitation or disagreement, please do open a PR still, but note your concerns as well. | |||
| Before you do, would you mind reading [this license agreement](LICENSE.md)? If you open a PR, we'll assume you agree to it. If you have any hesitation or disagreement, please do open a PR still, but note your concerns as well. | |||
There was a problem hiding this comment.
We've done away with the CLA.md I think you could kill this whole paragraph.
| @@ -28,7 +28,7 @@ Guidelines for bug reports: | |||
|
|
|||
| 2. **Check if the issue has been fixed** — try to reproduce it using the latest `master` or development branch in the repository. | |||
|
|
|||
| 3. **Isolate the problem** — ideally create a [reduced test case](http://css-tricks.com/6263-reduced-test-cases/) and a live example. | |||
| 3. **Isolate the problem** — ideally create a [reduced test case](https://css-tricks.com/reduced-test-cases/) and a live example. | |||
|
@jonrohan I'm more than happy to contribute and help! Removed the paragraph that you suggested with my latest commit 💯 |
This was referenced Mar 21, 2018
This was referenced Dec 20, 2022
This was referenced Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #444
There are some dead links in the contributing.md file so I deciced to clear and fix things up.
My only issue is with what to replace the dead link inreduced test case. So if anyone has an idea with what may I replace it with please let me know.Update: Fixed it!
TO-DO
Isolate the problem — ideally create a reduced test case and a live example./cc @primer/ds-core