Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add !important to details visibility override #446

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Add !important to details visibility override #446

merged 1 commit into from
Feb 28, 2018

Conversation

muan
Copy link
Contributor

@muan muan commented Feb 7, 2018

Fixes this case:

<details>
  <summary>summary</summary>
  <div class="d-flex">this shows up regardless</div>
</details>

d-flex has !important so it overrides the details default.

/cc @primer/ds-core

@muan
Add !important to details visibility override
11957e0 
This allows we use .d-flex or similar in inside of details
@broccolini
Copy link
Member

Thanks @muan - will add this to our next minor release.

@muan
Copy link
Contributor Author

muan commented Feb 21, 2018

@broccolini do you know when that might be?

@jonrohan jonrohan mentioned this pull request Feb 28, 2018
Closed
11 tasks
@jonrohan jonrohan changed the base branch from dev to release-10.4.0 February 28, 2018 18:55
@jonrohan jonrohan merged commit 107fcf1 into release-10.4.0 Feb 28, 2018
@jonrohan jonrohan deleted the muan/details branch February 28, 2018 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muan @broccolini @jonrohan