Button border-radius fix #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonrohan
requested changes
Nov 3, 2017
CHANGELOG.md
Outdated
| @@ -1,3 +1,8 @@ | |||
| # 9.6.1 | |||
There was a problem hiding this comment.
I'm ok pushing this into 10, and working on getting that out soon.
modules/primer-buttons/stories.js
Outdated
| @@ -2,6 +2,9 @@ import React from 'react' | |||
| import { storiesOf } from '@storybook/react' | |||
|
|
|||
| storiesOf('Button', module) | |||
| .add('button', () => ( | |||
| <button>Button</button> | |||
There was a problem hiding this comment.
What's the purpose of this here? Wouldn't it be better if we put stories in primer-base?
modules/primer-css/CHANGELOG.md
Outdated
| @@ -0,0 +1,305 @@ | |||
| # 9.6.1 | |||
There was a problem hiding this comment.
Don't put this file here, the build will publish the changelog. I think I might have done something wrong with the 9.6 release.
| @@ -1,7 +1,7 @@ | |||
| # Primer Stylelint Config | |||
|
|
|||
| [](https://www.npmjs.org/package/stylelint-config-primer) | |||
| [](https://travis-ci.org/primer/stylelint-config-primer) | |||
| [](https://travis-ci.org/primer/primer-css) | |||
| @@ -22,6 +22,7 @@ | |||
| "stylelint-selector-no-utility": "1.8.0" | |||
| }, | |||
| "devDependencies": { | |||
| "ava": "^0.23.0", | |||
There was a problem hiding this comment.
We don't need this here, ava dependency is hoisted to the main package.json
28 tasks
jonrohan
reviewed
Nov 8, 2017
package.json
Outdated
| "bump": "lerna publish --exact --skip-npm --since \"v$(npm info primer-css version)\"", | ||
| "new-module": "script/new-module", | ||
| "test": "lerna run test" | ||
| }, | ||
| "devDependencies": { | ||
| "@storybook/addon-options": "^3.2.6", | ||
| "@storybook/react": "^3.2.12", | ||
| "ava": "^0.21.0", |
There was a problem hiding this comment.
this should stay, and be updated to ^0.23.0
| @@ -22,6 +22,7 @@ | |||
| "stylelint-selector-no-utility": "1.8.0" | |||
| }, | |||
| "devDependencies": { | |||
| "ava": "^0.23.0", | |||
CHANGELOG.md
Outdated
| @@ -1,3 +1,8 @@ | |||
| # 9.6.1 | |||
This was referenced Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #387
In this pr:
border-radius: 0to override the4pxborder added since Chroma 62primer-stylelint-configreadme to point toprimer-cssPR in tested in github https://github.com/github/github/pull/81067
cc @primer/ds-core