Change markdown li break to handle Safari 10.x user stylesheet bug #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonrohan
approved these changes
Oct 6, 2017
|
Thanks @jonrohan 😊 ! What's the procedure for merging? I don't have merge access 🌮 |
We'll need to figure out what version we can merge this into, should be going out soon. 9.6 or 10.0. Is there anything hung up on this work? |
|
Nope! It's just a bug fix for a minor UI thing that has been open for awhile - not critical, definitely in the "nice to fix" category! |
|
Let's include it in v10! Thanks, @feministy 🍻 |
28 tasks
This was referenced Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey friends 👋 !
I am working on some bugs internally that are related to how long bullets in the body of an issue, PR, and project card are wrapping in Safari. I'm testing locally in Safari 10.1.2 and Chrome 61.0.3163.100 (wow that is a long version number). This bug does not happen with Safari 11.
Based on the testing I've been doing, it looks like
word-wrap: break-word;behaves differently for whendisplayis set tolist-item. Once I change thatdisplayproperty to literally anything else the bug fixes itself, but we lose the bullet formatting. Changing thelielements to wrap asbreak-allresolves the issue in Safari, and there are no visible changes in Chrome. I'm happy to screen share with one of y'all and show you what I've been testing over here if you're having trouble reproducing or have a newer version of Safari 😊 !I'm super new to our CSS and did some poking around in the documentation to see how to go about changing this for dotcom. I am not sure that changing this in Primer is the best approach, but it seems like overriding the Markdown
liformatting in our stylesheets for a browser bug is not the right way to go about this either. My thinking regarding changing it in Primer was that because it's a bug with Safari 10.x that is not isolated to GitHub's internal styles, it will impact other folks using Primer. However since this is a bug restricted to an older version of Safari, I can see how we wouldn't want that bloat here.Let me know what you think! 🙇♀️ Happy to pair on an alternative solution also 👏 💯
/cc @primer/ds-core