Release 9.5.0 #353

shawnbot · 2017-09-22T21:29:51Z

Changes

Thanks to @muan, it's now possible to style <summary> elements as buttons and have them appear in the active/selected state when the enclosing <details> element is open. Style buttons as selected on <details open> #346
Fixes Release candidate version logic is fragile #350 by changing our release candidate versioning logic so that prerelease increments are done on a per-module basis.

TODO

Bump primer-support (and all dependents) by a minor version
Add docs/examples for <details> button addition
Test fix for Release candidate version logic is fragile #350 (see this build)
Update CHANGELOG.md with v9.4.0 and v9.5.0 changes

/cc @primer/ds-core

Style buttons as selected on <details open>

- primer-alerts@1.5.0 - primer-avatars@1.4.0 - primer-base@1.5.0 - primer-blankslate@1.4.0 - primer-box@2.5.0 - primer-breadcrumb@1.4.0 - primer-buttons@2.4.0 - primer-cards@0.5.0 - primer-core@6.4.0 - primer-css@9.5.0 - primer-forms@1.4.0 - primer-labels@1.5.0 - primer-layout@1.4.0 - primer-markdown@3.7.0 - primer-marketing-type@1.4.0 - primer-marketing-utilities@1.4.0 - primer-marketing@5.4.0 - primer-navigation@1.4.0 - primer-page-headers@1.4.0 - primer-page-sections@1.4.0 - primer-product@5.4.0 - primer-support@4.4.0 - primer-table-object@1.4.0 - primer-tables@1.4.0 - primer-tooltips@1.4.0 - primer-truncate@1.4.0 - primer-utilities@4.8.0

broccolini

Left a few comments 💬

broccolini · 2017-09-22T23:22:34Z

CHANGELOG.md

+# 9.5.0
+
+### Added
+- Thanks to @muan, it's now possible to style `<summary>` elements as buttons and have them appear in the active/selected state when the enclosing [`<details>` element](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details) is open. #346


This feels inconsistent with our format of "added", "changed" etc. To thank people I'd rather have a "thanks to contributions from..." section for each release. For example @JasonEtco contributed to the last release and we didn't thank him 😢

broccolini · 2017-09-22T23:28:13Z

modules/primer-buttons/README.md

@@ -245,6 +245,21 @@ Use `.hidden-text-expander` to indicate and toggle hidden text.

 You can also make the expander appear inline by adding `.inline`.

+
+#### `<details>`/`<summary>` button styles


I don't think we should use code snippets in the title, that will be a bit odd when rendered in the toc and will look odd in the title.

broccolini · 2017-09-22T23:36:21Z

modules/primer-buttons/README.md

+
+You can apply `.btn` classes to `<summary>` elements, and they the
+selected/active styles will be applied when the parent `<details>` is open.
+


Thinking about it, I'm not sure these docs fit here, I think they'd fit better with the details component when we add that module to Primer.

I'm on the fence about this. My original sense was that people might want to know where they can use button styles, and that this doesn't exactly overlap with the Details component because it doesn't use any of those classes. How would you feel about leaving this here for now so we can get the release out, then addressing its placement in a future release?

broccolini

Left some suggestions for changes to docs as wasn't feeling quite right. I'm cool with shipping the docs here, I think we should also add this example to the details element docs when we work on those too though.

broccolini · 2017-10-02T22:40:42Z

modules/primer-buttons/README.md

@@ -245,6 +245,21 @@ Use `.hidden-text-expander` to indicate and toggle hidden text.

 You can also make the expander appear inline by adding `.inline`.

+
+#### Details element summary buttons


Suggest changing to Using button styles with the details summary element so that it's more "button focussed" 😏

broccolini · 2017-10-02T22:54:18Z

modules/primer-buttons/README.md

+#### Details element summary buttons
+
+You can apply `.btn` classes to `<summary>` elements, and they the
+selected/active styles will be applied when the parent `<details>` is open.


Looks like there are some typos here and could do with some tweaks. Suggest:

You can apply the btn class to the <summary> element so that it gains the appearance of a button, and selected/active styles when the parent <details> is open.

Thanks. I meant that you can actually use btn and any of the btn-* classes, but that wasn't clear.

shawnbot · 2017-10-02T23:29:52Z

@broccolini thanks for the feedback! Can you look at the changes in c996a22 and approve if they're good?

broccolini

👍 LGTM!

muan and others added 3 commits September 13, 2017 17:59

Make selected state work on opening <details>

be74c71

Merge branch 'dev' into muan/details-open

af4e61b

Merge pull request #346 from primer/muan/details-open

27762e3

Style buttons as selected on <details open>

shawnbot requested a review from broccolini September 22, 2017 21:29

shawnbot added 8 commits September 22, 2017 14:37

add <details>/<summary> example to primer-buttons

264e88a

add per-module RC bump script

b36b5a5

nicer output

bc9a4a2

use bump-rc script for each module

ecea6f6

update changelog for v9.4.0

faa2f29

use - instead of * for lists

c399f6d

add changelog entry for v9.5.0

3ac3fab

shawnbot changed the title ~~[WIP] Release 9.5.0~~ Release 9.5.0 Sep 22, 2017

broccolini reviewed Sep 22, 2017

View reviewed changes

shawnbot added 7 commits September 22, 2017 16:44

nix callout in v9.5.0 changes

e1a6457

nix inline code bits in details/summary example

3063092

don't exit form script/release-candidate

c5d61a4

fix the publish tag

80e2bfc

match all modules 🤦

c822a22

semver is dumb

e4c51b2

alphanumeric semver sorting is dumb; just get the last one

c81a3c3

broccolini reviewed Oct 2, 2017

View reviewed changes

tidy up details/summary button description

c996a22

broccolini approved these changes Oct 3, 2017

View reviewed changes

shawnbot mentioned this pull request Oct 4, 2017

Release candidate version logic is fragile #350

Closed

shawnbot merged commit 3190c9c into master Oct 4, 2017

shawnbot deleted the release-9.5.0 branch October 4, 2017 18:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 9.5.0 #353

Release 9.5.0 #353

shawnbot commented Sep 22, 2017 •

edited

Loading

broccolini left a comment

broccolini Sep 22, 2017

broccolini Sep 22, 2017

broccolini Sep 22, 2017

shawnbot Sep 22, 2017

broccolini left a comment

broccolini Oct 2, 2017

broccolini Oct 2, 2017

shawnbot Oct 2, 2017

shawnbot commented Oct 2, 2017

broccolini left a comment

		@@ -245,6 +245,21 @@ Use `.hidden-text-expander` to indicate and toggle hidden text.

		You can also make the expander appear inline by adding `.inline`.


		#### `<details>`/`<summary>` button styles


		You can apply `.btn` classes to `<summary>` elements, and they the
		selected/active styles will be applied when the parent `<details>` is open.

		@@ -245,6 +245,21 @@ Use `.hidden-text-expander` to indicate and toggle hidden text.

		You can also make the expander appear inline by adding `.inline`.


		#### Details element summary buttons

Release 9.5.0 #353

Release 9.5.0 #353

Conversation

shawnbot commented Sep 22, 2017 • edited Loading

Changes

TODO

broccolini left a comment

Choose a reason for hiding this comment

broccolini Sep 22, 2017

Choose a reason for hiding this comment

broccolini Sep 22, 2017

Choose a reason for hiding this comment

broccolini Sep 22, 2017

Choose a reason for hiding this comment

shawnbot Sep 22, 2017

Choose a reason for hiding this comment

broccolini left a comment

Choose a reason for hiding this comment

broccolini Oct 2, 2017

Choose a reason for hiding this comment

broccolini Oct 2, 2017

Choose a reason for hiding this comment

shawnbot Oct 2, 2017

Choose a reason for hiding this comment

shawnbot commented Oct 2, 2017

broccolini left a comment

Choose a reason for hiding this comment

shawnbot commented Sep 22, 2017 •

edited

Loading