Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hasPane default value for Layout stories #2030

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Fix hasPane default value for Layout stories #2030

merged 2 commits into from
Apr 12, 2022
+11 −0

Conversation

vdepizzol
Copy link
Contributor

What are you trying to accomplish?

A quick fix for layout component stories. A follow-up of #1989.

This update makes sure hasPane default value is true and is exposed as part of the SplitPageLayout story.

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@vdepizzol vdepizzol requested a review from a team as a code owner April 12, 2022 19:10
@vdepizzol vdepizzol requested a review from jonrohan April 12, 2022 19:10
@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 398db0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jonrohan
jonrohan approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks

@jonrohan jonrohan enabled auto-merge (squash) April 12, 2022 19:14
@jonrohan jonrohan merged commit 17c4536 into main Apr 12, 2022
@jonrohan jonrohan deleted the storybook-hasPane-examples-fix branch April 12, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

Assignees
No one assigned
Labels
storybook
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vdepizzol @jonrohan