Remove popover responsive hack
#1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ac124d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonrohan
approved these changes
Nov 22, 2021
Merged
simurai
reviewed
Nov 23, 2021
Comment on lines
+202
to
+205
| top: auto; | ||
| right: 0; | ||
| bottom: 0; | ||
| left: 0; |
There was a problem hiding this comment.
@langermank Sorry this is too late and would need to be a follow-up PR.
But we might wanna keep the !important. There are cases where Popovers are positioned manually to adjust to certain content. E.g. using right: -327px; bottom: -8px.
Also the width of the Popover-message that probably gets customized too. E.g. width: 250px;
There was a problem hiding this comment.
Ah! No problem, will follow up with a fix. Thanks :)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Popoverhack into Primer CSS, removing.page-responsive767pxPopoverwill be full-width and without caretBoxFixes: https://github.com/github/primer/issues/324
/cc @primer/css-reviewers