Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing deprecated variables with color v2 variables #1575

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Sep 7, 2021

This PR uses the primer/no-deprecated-colors stylelint plugin to replace the deprecated color vars in the codebase with new vars.

📈 This process found 180 unique deprecated variables, and replaced them with 39 unique color modes v2 variables. Resulting in an 80% reduction in color api surface area.

@jonrohan jonrohan requested a review from a team as a code owner September 7, 2021 16:36
@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2021

🦋 Changeset detected

Latest commit: 83fc89b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing --color-bg-overlay seems to be correct this time. 👍 Hopefully the rest is fine too. 🤞

@jonrohan jonrohan merged commit c7ea644 into main Sep 8, 2021
@jonrohan jonrohan deleted the correct_stylelint branch September 8, 2021 16:27
This was referenced Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants