Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced old octicons in examples #1165

Merged
merged 3 commits into from
Sep 9, 2020
Merged

Replaced old octicons in examples #1165

merged 3 commits into from
Sep 9, 2020

Conversation

ashygee
Copy link
Contributor

@ashygee ashygee commented Sep 8, 2020

Replaces svg for octicon button examples to use the new octicons.

/cc @primer/ds-core

@ashygee ashygee requested a review from simurai September 8, 2020 23:28
@vercel
Copy link

vercel bot commented Sep 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-css/31c4r2yo9
✅ Preview: https://primer-css-git-replace-octicons.primer.vercel.app

@vercel vercel bot temporarily deployed to Preview September 9, 2020 00:31 Inactive
@vercel vercel bot temporarily deployed to Preview September 9, 2020 00:32 Inactive
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢👍

@simurai simurai changed the base branch from master to release-15.2.0 September 9, 2020 01:40
@simurai simurai merged commit 58eb1f3 into release-15.2.0 Sep 9, 2020
@simurai simurai deleted the replace-octicons branch September 9, 2020 01:40
@simurai simurai mentioned this pull request Sep 10, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants