-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh polish ✨ #1041
Refresh polish ✨ #1041
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/jiw1axj9m |
The pressed state is still a bit hard to see. So now the background is also a bit darker:
Also added a subtle transition when moving with the mouse away from a button. 👉 Preview |
Played around with the different heights and added a new size scale to make sure all the heights match. $size-0: 0;
$size-1: 16px;
$size-2: 20px;
$size-3: 24px;
$size-4: 28px;
$size-5: 32px;
$size-6: 40px;
$size-7: 48px;
$size-8: 64px; 👀 Preview The current approach uses An alternative would be to add some padding back and use |
If someone wants to review this PR, I got carried away a bit and there are quite a lot of changes that move things around. 😇 But there should be no breaking change to dotcom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic!
This PR adds a bit more ✨ polish to the refreshed components. Like..
disabled
state to.form-control
.form-control
Label
andIssueLabel
are now the same) Stickersheet34px
👉32px
) Size stickersheetAPI changes
$size
scale.avatar-[1-8]
sizes..Label--large
modifier.Label--inline
modifier. This can be used in places where adding a label shouldn't increase the height of the container element or line-height, for example inside a<p>
element.$box-shadow-inset
variable. Used for the inner shadow of inputs$focus-shadow
👉$box-shadow-focus
/cc @primer/ds-core