-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New button style #1027
New button style #1027
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/m32a59cdq |
$btn-input-focus-shadow: 0 0 0 0.2em rgba($blue, 0.3) !default; // TODO: Deprecate? Replaced by $focus-shadow | ||
$btn-active-shadow: inset 0 0.15em 0.3em $black-fade-15 !default; // TODO: Deprecate? It's now unused. | ||
|
||
$focus-shadow: 0 0 0 3px rgba($blue, 0.4) !default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new variable without the btn
in the name that we might can use with inputs and other components.
Ok, I'm gonna go ahead and merge it into #1025 and start testing it on dotcom. Pretty sure we'll need to come back and make additional fixes/changes. |
This updates the buttons.
👀 Preview
It's probably not the final version, but maybe ok to start testing on dotcom.
TODO
colors.scss
TODO in a next phase
.btn-blue
button. It's rare, but still gets used..social-count
? Instead we could use aBtnGroup
.