Skip to content

Commit

Permalink
Removing v2 color mode css variable fallbacks (#1579)
Browse files Browse the repository at this point in the history
* Removing v2 color mode fallbacks

* Create shaggy-shirts-camp.md
  • Loading branch information
jonrohan authored Sep 9, 2021
1 parent c7ea644 commit c3b4a0c
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .changeset/shaggy-shirts-camp.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/css": minor
---

Removing v2 color mode css var fallbacks. `var(--color-v2, var(--color-v1))` becomes `var(--color-v2)`
2 changes: 1 addition & 1 deletion src/forms/form-control.scss
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ textarea.form-control {
// stylelint-disable-next-line primer/spacing
padding: 2px $spacer-1;
font-style: normal;
background: var(--color-attention-subtle, var(--color-auto-yellow-1));
background: var(--color-attention-subtle);
border-radius: $border-radius;
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/progress/progress.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
display: flex;
height: 8px;
overflow: hidden;
background-color: var(--color-neutral-muted, var(--color-auto-gray-2));
background-color: var(--color-neutral-muted);
border-radius: $border-radius;
outline: 1px solid transparent; // Support Firefox custom colors
}
Expand Down
4 changes: 2 additions & 2 deletions src/timeline/timeline-item.scss
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
flex-shrink: 0;

&--success {
color: var(--color-fg-on-emphasis, var(--color-btn-primary-text)); // TODO remove V1 fallback
background-color: var(--color-success-emphasis, var(--color-btn-primary-bg)); // TODO remove V1 fallback
color: var(--color-fg-on-emphasis);
background-color: var(--color-success-emphasis);
border: $border-width $border-style transparent;
}
}
Expand Down

0 comments on commit c3b4a0c

Please sign in to comment.