Merge pull request #379 from primer/deprecate-modules

Deprecating primer-cards and form-cards
primer · Oct 27, 2017 · 4b4d1cf · 4b4d1cf
2 parents ac032e1 + af82d99
commit 4b4d1cf
Show file tree

Hide file tree

Showing 11 changed files with 4 additions and 200 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,10 @@
 ### Added
 - New module `primer-subhead`. The Subhead is a simple header with a bottom border. It&#39;s designed to be used on settings and configuration pages.
 
+### Removed
+- Removing `primer-cards` module.
+- Removing `.form-cards` styles.
+
 # 9.6.0
 
 ### Added

diff --git a/modules/primer-cards/.npmignore b/modules/primer-cards/.npmignore
diff --git a/modules/primer-cards/LICENSE b/modules/primer-cards/LICENSE
diff --git a/modules/primer-cards/README.md b/modules/primer-cards/README.md
diff --git a/modules/primer-cards/index.scss b/modules/primer-cards/index.scss
diff --git a/modules/primer-cards/lib/cards.scss b/modules/primer-cards/lib/cards.scss
diff --git a/modules/primer-cards/package.json b/modules/primer-cards/package.json
diff --git a/modules/primer-css/package.json b/modules/primer-css/package.json
@@ -35,7 +35,6 @@
     "primer-branch-name": "0.0.1",
     "primer-breadcrumb": "1.4.1",
     "primer-buttons": "2.4.1",
-    "primer-cards": "0.5.1",
     "primer-core": "6.4.1",
     "primer-dropdown": "0.1.0",
     "primer-forms": "1.4.1",

diff --git a/modules/primer-forms/lib/form-validation.scss b/modules/primer-forms/lib/form-validation.scss
@@ -47,65 +47,6 @@ dl.form-group > dd {
   }
 }
 
-// Credit cards
-//
-// A selector for credit cards. Shows all credit cards we have available and
-// dims the non-selected ones.
-
-@warn "primer-forms: The credit cards component is being deprecated in next major version.";
-
-.form-cards {
-  height: 31px;
-  margin: 0 0 15px;
-
-  .card {
-    float: left;
-    width: 47px;
-    height: 31px;
-    text-indent: -9999px;
-    background-image: url("/images/modules/pricing/credit-cards-@1x.png");
-    background-position: 0 0;
-    opacity: 0.6;
-
-    &.visa { background-position: 0 0; }
-
-    &.amex { background-position: -50px 0; }
-
-    &.mastercard { background-position: -100px 0; }
-
-    &.discover { background-position: -150px 0; }
-
-    &.jcb { background-position: -200px 0; }
-
-    &.dinersclub { background-position: -250px 0; }
-
-    &.enabled { opacity: 1; }
-
-    &.disabled { opacity: 0.2; }
-  }
-
-  > .cards {
-    margin: 0;
-
-    > li {
-      float: left;
-      margin: 0 $spacer-1 0 0;
-      list-style-type: none;
-
-      &.text {
-        line-height: 31px;
-      }
-    }
-  }
-}
-
-@include retina-media-query {
-  .form-cards > .cards .card {
-    background-image: url("/images/modules/pricing/credit-cards-@2x.png");
-    background-size: 300px 31px;
-  }
-}
-
 // Inline verification
 // This overrides primer's inline form stuff
 .status-indicator {

diff --git a/modules/primer-marketing/index.scss b/modules/primer-marketing/index.scss
@@ -16,7 +16,6 @@
 
 // marketing specific css modules
 @import "primer-marketing-type/index.scss";
-@import "primer-cards/index.scss";
 @import "primer-page-headers/index.scss";
 @import "primer-page-sections/index.scss";
 @import "primer-tables/index.scss";

diff --git a/modules/primer-marketing/package.json b/modules/primer-marketing/package.json
@@ -26,7 +26,6 @@
     "lint": "../../script/lint-scss"
   },
   "dependencies": {
-    "primer-cards": "0.5.1",
     "primer-marketing-support": "1.3.1",
     "primer-marketing-type": "1.4.1",
     "primer-marketing-utilities": "1.4.1",