Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MultiSelect filter prop #49

Closed
wants to merge 3 commits into from
Closed

Fix MultiSelect filter prop #49

wants to merge 3 commits into from

Conversation

lochstar
Copy link
Contributor

@lochstar lochstar commented Sep 3, 2019

Hi,

I noticed :filter="false" was not working for the MultiSelect component. I've fixed it and also updated the docs to display false as the default value.

The disabled prop also doesn't appear to be working correctly, I've prevented the select from opening when disabled.

A couple of questions regarding the component:

  1. I also noticed there isn't a way to disable the "Select All" header with a prop, however it can be done via CSS. Did you want to include another prop to hide this feature?
  2. Would you accept a PR for a close-on-select prop?
  3. Would you accept a PR to limit the amount of options that can be selected?

Regards

@cagataycivici
Copy link
Member

Merged manually thanks.

tugcekucukoglu pushed a commit that referenced this pull request Feb 19, 2025
fix: hide clear icon when options array is empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants