Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divider: classNames are being used twice #7709

Closed
maxchan23 opened this issue Feb 16, 2025 · 1 comment · Fixed by #7711
Closed

Divider: classNames are being used twice #7709

maxchan23 opened this issue Feb 16, 2025 · 1 comment · Fixed by #7711
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@maxchan23
Copy link

Describe the bug

When I'm adding classes to a divider component, I noticed that the classes were being prepended and appended to the class list

Reproducer

https://stackblitz.com/edit/zry6flrc?file=src%2FApp.jsx

System Information

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    primereact: latest => 10.9.2 
    react: 18.3.1 => 18.3.1

Steps to reproduce the behavior

  1. Add any class names to any of the Divider components
  2. Inspect the Divider element
  3. The given className is being prepended and appended to the class list
Image

Expected behavior

The provided classNames should only be applied once

@maxchan23 maxchan23 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 16, 2025
@tanerengiiin tanerengiiin added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 17, 2025
melloware added a commit to melloware/primereact that referenced this issue Feb 17, 2025
@melloware melloware self-assigned this Feb 17, 2025
@melloware melloware added this to the 10.9.3 milestone Feb 17, 2025
@melloware
Copy link
Member

Thanks for the report! PR submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants