-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace eslint-plugin-typescript with @typescript-eslint/eslint-plugin #74
Conversation
seems tests are failing because while we might check existence of |
I think we can make a breaking change. I need to make a major version bump anyway for #71. |
@KagamiChan and @lydell |
I change |
Nice!
Tip: Never change the version number in a PR to any project. That’s typically done in a separate commit before releasing. |
I finish my work to do for this pull request.
|
@lydell are you happy with this PR now? |
Thanks! I’ll try to make the v4 release this weekend. |
Thank you! I'm looking forward to applying this change to my project! |
v4.0.0 is now released! |
Wow! Thank you!
2019年1月26日(土) 19:56 Simon Lydell <notifications@github.com>:
… v4.0.0 is now released!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEyY_kwQ9OgwI9MMYMRZcEgPNqceKrlTks5vHDRVgaJpZM4aJ_l4>
.
|
In a few days ago, ESLint launched new project typescript-eslint which uses the new namespace
@typescript-eslint/rule-name
for rules. This pull request is for that changes. Cheers!