Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace eslint-plugin-typescript with @typescript-eslint/eslint-plugin #74

Merged
merged 9 commits into from
Jan 22, 2019
Merged

Conversation

tani
Copy link

@tani tani commented Jan 21, 2019

In a few days ago, ESLint launched new project typescript-eslint which uses the new namespace @typescript-eslint/rule-name for rules. This pull request is for that changes. Cheers!

@KagamiChan
Copy link

seems tests are failing because @typescript-eslint/eslint-plugin is not listed as dev dep

while we might check existence of @typescript-eslint/eslint-plugin and determine which rule set is used, a breaking change is better IMO

@lydell
Copy link
Member

lydell commented Jan 21, 2019

I think we can make a breaking change. I need to make a major version bump anyway for #71.

@tani
Copy link
Author

tani commented Jan 21, 2019

@KagamiChan and @lydell
I see, I remove old rules and update dependencies.

@tani
Copy link
Author

tani commented Jan 21, 2019

I change eslint-plugin-typescript to @typescript-eslint/eslint-plugin to pass test, but I don't change version number because it may be able to do it at #71.

@lydell
Copy link
Member

lydell commented Jan 21, 2019

Nice!

I don't change version number

Tip: Never change the version number in a PR to any project. That’s typically done in a separate commit before releasing.

@tani
Copy link
Author

tani commented Jan 21, 2019

I finish my work to do for this pull request.

  • document README.md
  • test test/*.js
  • dependencies package.json and package-lock.json

@JamesHenry
Copy link

@lydell are you happy with this PR now?

@lydell lydell changed the base branch from master to v4 January 22, 2019 17:07
@lydell lydell changed the title Add @typescript-eslint rules Replace eslint-plugin-typescript with @typescript-eslint rules/eslint-plugin Jan 22, 2019
@lydell lydell changed the title Replace eslint-plugin-typescript with @typescript-eslint rules/eslint-plugin Replace eslint-plugin-typescript with @typescript-eslint/eslint-plugin Jan 22, 2019
@lydell lydell merged commit d1254cd into prettier:v4 Jan 22, 2019
@lydell
Copy link
Member

lydell commented Jan 22, 2019

Thanks! I’ll try to make the v4 release this weekend.

@tani
Copy link
Author

tani commented Jan 22, 2019

Thank you! I'm looking forward to applying this change to my project!

@lydell
Copy link
Member

lydell commented Jan 26, 2019

v4.0.0 is now released!

@tani
Copy link
Author

tani commented Jan 26, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants