Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add registerProperty back for fbcode usage #24653

Merged
merged 1 commit into from
Mar 1, 2025
Merged

Add registerProperty back for fbcode usage #24653

merged 1 commit into from
Mar 1, 2025
+23 −0

Conversation

vhsu14
Copy link
Contributor

@vhsu14 vhsu14 commented Feb 28, 2025 •
edited
Loading

Description

registerProperty is used in fbcode, deleting it broke internal tests, thus adding it back.

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... 
* ... 

Hive Connector Changes
* ... 
* ...

If release note is NOT required, use:

== NO RELEASE NOTE ==

@vhsu14 vhsu14 requested a review from a team as a code owner February 28, 2025 17:56
@vhsu14 vhsu14 force-pushed the fix-cpp-diff-train branch from 70faae4 to c36c236 Compare February 28, 2025 18:14
zation99
zation99 previously approved these changes Feb 28, 2025
View reviewed changes
spershin
spershin previously approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@spershin spershin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

aditi-pandit
aditi-pandit reviewed Feb 28, 2025
View reviewed changes
Copy link
Contributor

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vhsu14

@vhsu14 vhsu14 dismissed stale reviews from spershin and zation99 via 2db0b00 February 28, 2025 19:47
@vhsu14 vhsu14 force-pushed the fix-cpp-diff-train branch from c36c236 to 2db0b00 Compare February 28, 2025 19:47
@vhsu14 vhsu14 requested a review from spershin February 28, 2025 21:51
@vhsu14 vhsu14 merged commit 27469d0 into prestodb:master Mar 1, 2025
60 checks passed
This was referenced Mar 10, 2025
Closed
Closed
jp-sivaprasad pushed a commit to jp-sivaprasad/presto that referenced this pull request Mar 10, 2025
@vhsu14 @jp-sivaprasad
Add registerProperty back for fbcode usage (prestodb#24653)
180b7b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditi-pandit aditi-pandit aditi-pandit left review comments

@spershin spershin spershin approved these changes

@zation99 zation99 zation99 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vhsu14 @spershin @zation99 @aditi-pandit