[native] Fix includes #24625
Merged
[native] Fix includes #24625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request was exported from Phabricator. Differential Revision: D70195333 |
majetideepak
requested changes
Feb 25, 2025
joeg
added a commit
to joeg/presto
that referenced
this pull request
Feb 25, 2025
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it Reviewed By: karteekmurthys Differential Revision: D70195333
438732a to
39ef4d1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70195333 |
joeg
added a commit
to joeg/presto
that referenced
this pull request
Feb 25, 2025
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it Reviewed By: karteekmurthys Differential Revision: D70195333
39ef4d1 to
2325c23
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70195333 |
swapsmagic
approved these changes
Feb 25, 2025
joeg
added a commit
to joeg/presto
that referenced
this pull request
Feb 26, 2025
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it Reviewed By: swapsmagic, karteekmurthys Differential Revision: D70195333
2325c23 to
fa7fa18
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70195333 |
joeg
added a commit
to joeg/presto
that referenced
this pull request
Feb 26, 2025
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it Reviewed By: swapsmagic, karteekmurthys Differential Revision: D70195333
fa7fa18 to
0cc9224
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70195333 |
joeg
added a commit
to joeg/presto
that referenced
this pull request
Feb 26, 2025
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it Reviewed By: swapsmagic, karteekmurthys Differential Revision: D70195333
0cc9224 to
986bbd9
Compare
|
Saved that user @joeg is from Meta |
joeg
added a commit
to joeg/presto
that referenced
this pull request
Feb 26, 2025
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it Reviewed By: swapsmagic, karteekmurthys Differential Revision: D70195333
986bbd9 to
0d95cc3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70195333 |
majetideepak
approved these changes
Feb 27, 2025
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it Reviewed By: swapsmagic, karteekmurthys Differential Revision: D70195333
0d95cc3 to
d5d46ba
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70195333 |
This was referenced Mar 10, 2025
jp-sivaprasad
pushed a commit
to jp-sivaprasad/presto
that referenced
this pull request
Mar 10, 2025
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it Reviewed By: swapsmagic, karteekmurthys Differential Revision: D70195333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: simple fix, remove unused include & move #include "github/presto-trunk/presto-native-execution/presto_cpp/main/common/Utils.h" to the two cpp files that directly use it
Reviewed By: karteekmurthys
Differential Revision: D70195333