-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Move file-based metastore doc to installation/deployment.rst #24620
[docs] Move file-based metastore doc to installation/deployment.rst #24620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steveburnett Thank you! Just some minor nits.
I will let you know if I have any suggestions on the positioning of this within deployment.rst
2176bc1
to
fd4ea79
Compare
Thanks @imjalpreet! Nits addressed, please re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, apart from one minor suggestion
ad80687
to
e781c9c
Compare
e781c9c
to
ea88ce1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
trying to understand the motivation here better. why is connector not the right place for this documentation, since it is a specific configuration option for a few connectors? |
@rschlussel It was not very intuitive for end users to search for this documentation under connectors list. Connectors list is intended for listing and describing all the supported connectors. The documentation for FileHiveMetastore was previously added as a separate page under connectors. |
Got it. I'm not sure putting it in deployment is more intuitive than having it in connectors, but this is fine. I do think wherever they live, we should link to these docs from all the lakehouse connectors. |
Great idea! I opened #24623 to not forget this. |
Description
Motivation and Context
After #24511 was merged, a discussion began that suggested that /connector/ was not the best place in the Presto documentation for the file-based metastore configuration. Further discussion settled on moving it adjacent to the Configure Hive Metastore topic in installation/deployment.rst.
Impact
Readers may be able to find the file-based metastore documentation easier in this new location.
Test Plan
Local doc builds. Screenshot of relocated text:

Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.