Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade netty version to 4.1.118.Final #24586

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Upgrade netty version to 4.1.118.Final #24586

merged 1 commit into from
Mar 6, 2025

Conversation

infvg
Copy link
Contributor

@infvg infvg commented Feb 18, 2025 •
edited
Loading

Description

Upgrade netty version to 4.1.118.Final in response to CVE-2025-25193

Motivation and Context

This upgrade was created to deal with CVEs found in lower versions

Impact

None

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== RELEASE NOTES ==

General Changes
* Upgrade netty dependencies to version 4.1.115.Final in response to `CVE-2024-47535 <https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-47535>`

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 18, 2025
@infvg infvg marked this pull request as ready for review February 18, 2025 08:09
@infvg infvg requested a review from a team as a code owner February 18, 2025 08:09
@infvg infvg requested a review from presto-oss February 18, 2025 08:09
@ethanyzhang ethanyzhang requested review from a team, ShahimSharafudeen, Dilli-Babu-Godari and imjalpreet and removed request for a team February 19, 2025 20:26
@ShahimSharafudeen
Copy link
Contributor

Please follow the latest Release Notes Guidelines to remove the examples of manually adding the PR link.

imjalpreet
imjalpreet approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@imjalpreet imjalpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

agrawalreetika
agrawalreetika reviewed Feb 23, 2025
View reviewed changes
Copy link
Member

@agrawalreetika agrawalreetika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can update commit message to something like -

Upgrade netty version to 4.1.118.Final for resolving <CVE-Name>

@infvg
Upgrade netty version to 4.1.118.Final to resolve CVE-2025-25193
99902b5 
Upgrade netty version to 4.1.118.Final in response to CVE-2025-25193
@agrawalreetika agrawalreetika merged commit cb73e99 into prestodb:master Mar 6, 2025
53 checks passed
This was referenced Mar 10, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrawalreetika agrawalreetika agrawalreetika approved these changes

@imjalpreet imjalpreet imjalpreet approved these changes

@jaystarshot jaystarshot jaystarshot approved these changes

@ShahimSharafudeen ShahimSharafudeen ShahimSharafudeen approved these changes

@Dilli-Babu-Godari Dilli-Babu-Godari Dilli-Babu-Godari approved these changes

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

Assignees
No one assigned
Labels
from:IBM PR from IBM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@infvg @ShahimSharafudeen @imjalpreet @agrawalreetika @jaystarshot @Dilli-Babu-Godari @prestodb-ci