Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the number of task event loop configurable #24565

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

shangm2
Copy link
Contributor

@shangm2 shangm2 commented Feb 14, 2025

Description

  1. This pr makes the number of task event loop within the group configurable via the configuration file

Motivation and Context

  1. We saw event loop can get blocked while the underlying http connections are also being blocked
  2. This pr makes the number of event loop configurable to reduce the chance of getting blocked while still uses the number of cores as default value

Impact

Test Plan

  1. Deployed in pnb2_verifier_t1_1 with a configuration value of 500 for query replay
  2. Confirm the config is updated
Screenshot 2025-02-13 at 20 58 51
  1. Confirm 500 task event loop are being used in coordinator
Screenshot 2025-02-13 at 21 42 10

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Make the number of task event loop configurable via a configuration file

@shangm2 shangm2 requested a review from a team as a code owner February 14, 2025 05:52
@shangm2 shangm2 requested a review from presto-oss February 14, 2025 05:52
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Feb 14, 2025
@shangm2 shangm2 force-pushed the configurable_event_loop branch from c7d8d0a to 54189df Compare February 14, 2025 07:00
arhimondr
arhimondr previously approved these changes Feb 14, 2025
@arhimondr arhimondr merged commit 03b8cd9 into prestodb:master Feb 14, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:Meta PR from Meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants