Improve boostrap log to expose the wrong classLoader #24533
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D69416153 |
387ac9e to
659077c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69416153 |
|
nit: capitalize the commit title and remove references to internal connectors. |
|
Looks like you need a rebase to fix the maven checks |
Summary: Impulse class loader issue causing bootstrap exception Prev Caused by: java.lang.IllegalArgumentException: Expected com.facebook.presto.$gen.WeightedAverageStateSerializer_20250210_222951_7's classloader to be of type com.facebook.presto.bytecode.DynamicClassLoader, but is com.facebook.presto.bytecode.DynamicClassLoader Differential Revision: D69416153
659077c to
eef0892
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69416153 |
|
You still need to fix the commit message body. The current commit body includes references to an internal connector not in open source and isn't very comprehensible to someone without context. The body here doesn't actually need much because the change is pretty self explanatory. Something like the following should be sufficient: "Improve bootstrap error message for incorrect classloader to include what classloader was found." |
Summary: Improve bootstrap error message for incorrect classloader to include what classloader was found. Differential Revision: D69416153
eef0892 to
ee3acf7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69416153 |
Fixed, thanks! |
|
Thanks! |
Summary: Improve bootstrap error message for incorrect classloader to include what classloader was found. Differential Revision: D69416153
Summary:
Improve bootstrap error message for incorrect classloader to include what classloader was found.