Use builder pattern for IcebergQueryRunner #24515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa98c76 to
427a2f4
Compare
There was a problem hiding this comment.
Thanks for this refactor. Overall lgtm, the builder pattern is wonderful. One thing I can think of is that multiple catalogs with the same connector type may affect each other in JMX statistics. But we can add comments on IcebergQueryRunner.addCatalog(...) to clarify this.
presto-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergQueryRunner.java
Outdated
Show resolved
Hide resolved
presto-iceberg/src/test/java/com/facebook/presto/iceberg/hive/TestIcebergDistributedHive.java
Outdated
Show resolved
Hide resolved
presto-iceberg/src/test/java/com/facebook/presto/iceberg/hive/TestIcebergHiveStatistics.java
Outdated
Show resolved
Hide resolved
jaystarshot
previously approved these changes
Feb 14, 2025
|
lgtm, some properties are removed as @hantangwangd pointed out |
427a2f4 to
2bcf851
Compare
hantangwangd
previously approved these changes
Feb 18, 2025
2bcf851 to
625fce6
Compare
hantangwangd
previously approved these changes
Feb 19, 2025
Additionally, add support for tracking catalog properties added to iceberg. This can be useful for tests that may require their own catalogs
625fce6 to
2c11825
Compare
jaystarshot
approved these changes
Feb 20, 2025
aditi-pandit
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we create IcebergQueryRunner through a complicated set of method with various overloads. We tend to just create a new constructor/method for every time we need to set a separate property which can make figuring out
the arguments you're trying to explicitly change for a query runner more difficult to determine.
This change instead introduces a class which uses builder pattern to make it easier to add new features and use.
Motivation and Context
Simpler and easier to understand query runner.
Impact
N/A. Testing only
Test Plan
Existing tests
Contributor checklist
Release Notes