Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert " Upgrade Okie to version 3.6.0 and OkHttp to version 4.12.0" #24459

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

arhimondr
Copy link
Member

This reverts commit 01bdab4.

  • Dependency conflicts ignored here causing issues downstream
  • Kotlin dependencies (kotlin.*) as well as Jetbrains annotations (org.intellij.*, org.jetbrains.*) must be properly shaded in presto-jdbc (and potentially other modules requiting shading, needs confirmation)
== NO RELEASE NOTE ==

@arhimondr arhimondr requested a review from a team as a code owner January 29, 2025 23:48
@arhimondr arhimondr requested a review from presto-oss January 29, 2025 23:48
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Jan 29, 2025
Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arhimondr

@arhimondr arhimondr merged commit 08fe81c into prestodb:master Jan 30, 2025
54 checks passed
@arhimondr arhimondr deleted the revert_okhttp branch January 30, 2025 02:31
@ethanyzhang
Copy link
Contributor

@Mariamalmesfer can you look into this and reintroduce the fix?

@Mariamalmesfer
Copy link
Contributor

@Mariamalmesfer can you look into this and reintroduce the fix?

Sure, I'm on it! You can follow the progress on #24473 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:Meta PR from Meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants