-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade accumulo to 1.10.1 to fix CVE-2020-17533 #24438
Conversation
Thanks for the release note! Suggest adding the CVE that prompted the work, following the example in Phrasing in the Release Notes Guidelines.
|
c18bc79
to
3fd1279
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@namya28 Thanks for the fix! Could you confirm whether the CVE actually affects accumulo-core
? From what I see, CVE-2020-17533 specifically impacts accumulo-master
. In Presto, it might be present in accumulo-minicluster
due to its dependency on accumulo-master
, but I don’t believe it is directly related to accumulo-core
.
If that’s the case, we should update the PR title and commit messages accordingly. Let me know if I missed anything.
3fd1279
to
074d5d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@namya28 Thanks, I think below commit message would be better
Upgrade Accumulo to 1.10.1 to fix CVE-2020-17533
Upgrade the Accumulo version from 1.7.4 to 1.10.1 to address a security vulnerability (CVE-2020-17533). The affected library, accumulo-master, is a transitive dependency in Presto, coming from accumulo-minicluster.
The commit description will give more context to the fix.
074d5d4
to
31b55fb
Compare
31b55fb
to
1ec17aa
Compare
Thanks for the suggestion @imjalpreet . I have made the changes , rebased and pushed my changes again. |
Upgrade the accumulo version from 1.7.4 to 1.10.1 to address a security vulnerability (CVE-2020-17533). The affected library, accumulo-master, is a transitive dependency in Presto, coming from accumulo-minicluster.
1ec17aa
to
f9909a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@tdcmeehan another PR which is ready for final review. Please take a look whenever you get a chance, thanks! |
Description
This PR is for fixing the security vulnerability for accumulo. The version has been upgraded to 1.10.1 from the version 1.7.4 as the version 1.7.4 had a security vulnerability. This fixes CVE-2020-17533.
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.