-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate presto stable release pipeline from jenkins to github actions #24388
Conversation
|
Tested this action in my repo => https://github.com/unidevel/presto/actions/workflows/release-test.yml |
338182c
to
2e277c7
Compare
- name: Set up JDK 8 | ||
uses: actions/setup-java@v4 | ||
with: | ||
java-version: '8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we try it with an updated JDK version? It should have no bearing on the underlying project's version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried JDK 17, but it failed to run => https://github.com/unidevel/presto/actions/runs/12896366118
com.google.inject.ProvisionException: Unable to provision, see the following errors:
1) Error injecting constructor, java.lang.NoClassDefFoundError: Could not initialize class org.codehaus.groovy.vmplugin.v7.Java7
at org.codehaus.mojo.spotbugs.SpotBugsMojo.<init>(Unknown Source)
while locating org.codehaus.mojo.spotbugs.SpotBugsMojo
Then I tried with JDK 11, it works fine => https://github.com/unidevel/presto/actions/runs/12896408283
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JDK 17 is an in-progress effort, we should use JDK 11.
2e277c7
to
045a4eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR migrate the Jenkinsfile script from https://github.com/prestodb/presto-release-tools/blob/pipeline-release-stable/Jenkinsfile
Will update versions, and create new stable release branch
Motivation and Context
Impact
Presto release
Test Plan
Try with new release
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.