Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate presto stable release pipeline from jenkins to github actions #24388

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

unidevel
Copy link
Contributor

Description

This PR migrate the Jenkinsfile script from https://github.com/prestodb/presto-release-tools/blob/pipeline-release-stable/Jenkinsfile

Will update versions, and create new stable release branch

Motivation and Context

Impact

Presto release

Test Plan

Try with new release

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@unidevel unidevel requested a review from a team as a code owner January 17, 2025 16:36
@unidevel unidevel requested a review from presto-oss January 17, 2025 16:36
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 17, 2025
Copy link

linux-foundation-easycla bot commented Jan 17, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: unidevel / name: unidevel (045a4eb)

@prestodb-ci prestodb-ci requested review from a team, Dilli-Babu-Godari and namya28 and removed request for a team January 17, 2025 16:36
@tdcmeehan tdcmeehan self-assigned this Jan 17, 2025
@unidevel
Copy link
Contributor Author

@unidevel unidevel force-pushed the add_stable_release_actions branch from 338182c to 2e277c7 Compare January 20, 2025 20:04
- name: Set up JDK 8
uses: actions/setup-java@v4
with:
java-version: '8'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try it with an updated JDK version? It should have no bearing on the underlying project's version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried JDK 17, but it failed to run => https://github.com/unidevel/presto/actions/runs/12896366118

    com.google.inject.ProvisionException: Unable to provision, see the following errors:
    
    1) Error injecting constructor, java.lang.NoClassDefFoundError: Could not initialize class org.codehaus.groovy.vmplugin.v7.Java7
      at org.codehaus.mojo.spotbugs.SpotBugsMojo.<init>(Unknown Source)
      while locating org.codehaus.mojo.spotbugs.SpotBugsMojo
    

Then I tried with JDK 11, it works fine => https://github.com/unidevel/presto/actions/runs/12896408283

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JDK 17 is an in-progress effort, we should use JDK 11.

@unidevel unidevel force-pushed the add_stable_release_actions branch from 2e277c7 to 045a4eb Compare January 21, 2025 21:59
Copy link
Member

@wanglinsong wanglinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unidevel unidevel merged commit 15fd5d8 into prestodb:master Jan 22, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants