Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native] Disable Spark E2E test CI job #24361

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

czentgr
Copy link
Contributor

@czentgr czentgr commented Jan 14, 2025

The Spark E2E tests have been causing problems since migration from CircleCI to github actions. The latter includes more tests to be run that cause an instability in the pipeline because they were previously not run consistently. This resulted in them becoming flaky affecting the entire pipeline.

Issues have been opened to address the various observed failures.

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 14, 2025
@prestodb-ci prestodb-ci requested review from a team, anandamideShakyan and ShahimSharafudeen and removed request for a team January 14, 2025 15:39
@czentgr czentgr marked this pull request as ready for review January 14, 2025 22:40
@czentgr czentgr requested a review from a team as a code owner January 14, 2025 22:40
@czentgr czentgr requested a review from presto-oss January 14, 2025 22:40
@czentgr czentgr force-pushed the cz_disable_spark_e2e_tests branch from 505012c to ac52a9b Compare January 14, 2025 23:34
The Spark E2E tests have been causing problems since migration from
CircleCI to github actions. The latter includes more tests to be run that cause
an instability in the pipeline because they were previously not run consistently.
This resulted in them becoming flaky affecting the entire pipeline.

This PR explicitly runs tests from the previous CI as well as other selected
tests that are not flaky.

Excluded tests are
TestPrestoSparkNativeGeneralQueries
TestPrestoSparkNativeAggregations
TestPrestoSparkNativeJoinQueries
TestPrestoSparkNativeWindowQueries

Issues have been opened to address the various observed failures.
@czentgr czentgr force-pushed the cz_disable_spark_e2e_tests branch from ac52a9b to c67359c Compare January 15, 2025 04:04
@tdcmeehan tdcmeehan merged commit 85eeacf into prestodb:master Jan 15, 2025
56 checks passed
Joe-Abraham pushed a commit to Joe-Abraham/presto that referenced this pull request Jan 20, 2025
The Spark E2E tests have been causing problems since migration from
CircleCI to github actions. The latter includes more tests to be run that cause
an instability in the pipeline because they were previously not run consistently.
This resulted in them becoming flaky affecting the entire pipeline.

This PR explicitly runs tests from the previous CI as well as other selected
tests that are not flaky.

Excluded tests are
TestPrestoSparkNativeGeneralQueries
TestPrestoSparkNativeAggregations
TestPrestoSparkNativeJoinQueries
TestPrestoSparkNativeWindowQueries

Issues have been opened to address the various observed failures.
shangm2 pushed a commit to shangm2/presto that referenced this pull request Jan 21, 2025
The Spark E2E tests have been causing problems since migration from
CircleCI to github actions. The latter includes more tests to be run that cause
an instability in the pipeline because they were previously not run consistently.
This resulted in them becoming flaky affecting the entire pipeline.

This PR explicitly runs tests from the previous CI as well as other selected
tests that are not flaky.

Excluded tests are
TestPrestoSparkNativeGeneralQueries
TestPrestoSparkNativeAggregations
TestPrestoSparkNativeJoinQueries
TestPrestoSparkNativeWindowQueries

Issues have been opened to address the various observed failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants