Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session properties for scaled table scan configs to workers #24275

Closed

Conversation

natashasehgal
Copy link
Contributor

@natashasehgal natashasehgal commented Dec 18, 2024

Description

Follow up of #24284
Add session properties for scale writer query configs

table_scan_scaled_processing_enabled
table_scan_scale_up_memory_usage_ratio

Motivation and Context

Impact

Low impact

Test Plan

  • Added Unit Test
  • CI Tests passed
    Unrelated error
Error:  Failures: 
Error:    TestResourceManagerClusterStatusSender.testQueryHeartbeat:130 Expected at least one subsequent query heartbeat, previous: 10, current: 10 expected [true] but found [false]
[INFO] 
Error:  Tests run: 8540, Failures: 1, Errors: 0, Skipped: 1

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== RELEASE NOTES ==

Session changes
- Add session property: 'native_table_scan_scaled_processing_enabled' :pr:`24275 `
- Add session property: 'native_table_scan_scale_up_memory_usage_ratior' :pr:`24275 `

Copy link

linux-foundation-easycla bot commented Dec 18, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@natashasehgal natashasehgal force-pushed the nasehgal.T210844289 branch 2 times, most recently from d77fcf1 to 6a695b0 Compare December 18, 2024 11:50
@natashasehgal natashasehgal marked this pull request as draft December 20, 2024 08:20
@natashasehgal natashasehgal changed the title Add session properties for scaled table scan configs Add session properties for scaled table scan configs to workers Dec 20, 2024
@natashasehgal natashasehgal changed the base branch from master to wrapper January 2, 2025 17:25
@natashasehgal natashasehgal changed the base branch from wrapper to master January 2, 2025 17:25
@steveburnett
Copy link
Contributor

Thanks for the release note! A few suggestions and formatting nits:

== RELEASE NOTES ==

Prestissimo (Native Execution) Changes
- Add session property ``native_table_scan_scaled_processing_enabled`` :pr:`24275`
- Add session property:``native_table_scan_scale_up_memory_usage_ratio`` :pr:`24275`

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the doc for these session properties appears to be in #24284, there's nothing for me to review in this PR.

@natashasehgal natashasehgal marked this pull request as ready for review January 3, 2025 19:12
Copy link
Contributor

@gggrace14 gggrace14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks right to me!

@natashasehgal
Copy link
Contributor Author

Not required covered in #24284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants