Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CVE-2024-55565 #24273

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix CVE-2024-55565 #24273

merged 1 commit into from
Dec 18, 2024

Conversation

yhwang
Copy link
Member

@yhwang yhwang commented Dec 17, 2024

Description

update nanoid pkg to 3.3.8 to fix the CVE

Motivation and Context

CVE information: https://www.cve.org/CVERecord?id=CVE-2024-55565
The nanoid pkg is used in the Presto UI. Although, it is used as a dev tool. it's good to update the version.

Impact

N/A

Test Plan

Verify if all the UI pages work

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==
Fix the `CVE-2024-55565 <https://www.cve.org/CVERecord?id=CVE-2024-55565>`.
The ``nanoid`` pkg is used as a dev tool in the Presto UI. It's good to update the version
to avoid the CVE.

update nanoid pkg to 3.3.8 to fix the CVE

Signed-off-by: Yihong Wang <yh.wang@ibm.com>
@yhwang yhwang requested a review from a team as a code owner December 17, 2024 22:06
@yhwang yhwang requested a review from presto-oss December 17, 2024 22:06
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Dec 17, 2024
@prestodb-ci prestodb-ci requested review from a team, zuyu and BryanCutler and removed request for a team December 17, 2024 22:06
@yhwang
Copy link
Member Author

yhwang commented Dec 17, 2024

I manually verified that all pages of the Presto UI. All pages are working well.

@yhwang yhwang merged commit 7018880 into prestodb:master Dec 18, 2024
57 checks passed
@yhwang
Copy link
Member Author

yhwang commented Dec 18, 2024

small change and all CI passed. let me merge it

@yhwang yhwang deleted the fix-cve-2024-55565 branch December 18, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants