Fix setting iceberg table location on creation for REST/NESSIE catalog #24218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we ignore the specified table property
location
when creating tables on iceberg catalogs based onIcebergNativeMetadata
, this will result in that the newly created table's location always using default values, regardless of whether a custom location is explicitly specified or not.This behavior is somewhat unreasonable, as for catalogs that support specifying table locations on creation (like Rest and Nessie), the newly created table's location should be the specified path; while for catalogs that do not support specifying table locations on creation (like Hadoop), exceptions should be thrown directly.
This PR fix the above problem, pass the specified table
location
to Iceberg lib when creating tables on catalogs based onIcebergNativeMetadata
.Motivation and Context
Support specifying table location on creation for Iceberg connector on as many catalog types as possible.
Impact
Iceberg connector configured with REST and NESSIE catalogs now support specifying table location on creation.
Iceberg connector configured with HADOOP catalogs now fail directly when specifying table location on creation.
Test Plan
Contributor checklist
Release Notes