-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native] Add two new parameters for trace control #24209
[native] Add two new parameters for trace control #24209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zation99 looks good % comments. We will deprecate the existing session property for task regular expr in followup? Thanks!
presto-native-execution/presto_cpp/main/QueryContextManager.cpp
Outdated
Show resolved
Hide resolved
Please add documentation for these properties to the appropriate pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zation99 LGTM. Thanks!
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zation99 : Please can you merge all your commits into a single one with the same title as this PR.
Yes I'll do "Squash and merge" when merging the PR. |
16d14fd
to
abcb06c
Compare
Saved that user @zation99 is from Meta |
|
@aditi-pandit do you have any other comment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zation99
Add two new parameters for trace control
Description
This is to improve the trace control experience. We added two new properties:
Once specified, we automatically create a regex for Velox to match the taskID pattern, so developers don't need to compose the complicated regex themselves, and it is controlled at Prestissimo level.
If native_query_trace_task_reg_exp is also provided, it will be overridden.
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.