-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support nested namespaces in Iceberg's REST Catalog #24083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull branch, local doc build, looks good. Thanks for the doc!
Suggest revising the release note entry to follow the Order of changes in the Release Notes Guidelines, and formatting.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this - I know it's a desired feature! I have one NIT below. My only other doubt is the subclassing of the ~100 tests in TestIcebergSmokeRest
as opposed to having a select few tests. I tend to stand on the "more tests the better" side of things but just thinking out loud 🙂
presto-iceberg/src/main/java/com/facebook/presto/iceberg/util/IcebergPrestoModelConverters.java
Outdated
Show resolved
Hide resolved
The configuration property iceberg.rest.nested.namespace.enabled allows nested namespace in Iceberg's REST Catalog
16e4c43
to
b230bf9
Compare
@kiersten-stokes, we wanted to make sure all features work with nested namespaces, but let us know if you have a better suggestion! |
The failing test, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Agreed about the tests :)
@denodo-research-labs can you create issues for creating native tests against Polaris and Unity catalogs, and note the dependent issues that block this? I agree we need such tests and it would be great to not lose track of that. |
Description
Support nested namespaces in Iceberg's REST Catalog. The configuration property
iceberg.rest.nested.namespace.enabled
enables this feature (default:true
).Motivation and Context
Invalid two-part namespace unity
.Impact
Namespaces in Polaris can be nested up to 16 levels. If a large number of recursive namespaces result in lower performance, querying nested namespaces can be disabled:
iceberg.rest.nested.namespace.enabled=false
Test Plan
TestIcebergSmokeRestNestedNamespace
that uses the nested namespace:"ns1.ns2"
for all operations.Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.