Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native] Disable Parsing Decimal as Double #24065

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

zuyu
Copy link
Contributor

@zuyu zuyu commented Nov 17, 2024

Turn off this knob, make it consistent w/ Presto Java since 0.198 to avoid #23754.

After 0.198 they are parsed as DECIMAL.

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Nov 17, 2024
@zuyu zuyu marked this pull request as ready for review November 18, 2024 21:41
@zuyu zuyu requested a review from a team as a code owner November 18, 2024 21:41
Copy link
Contributor

@yingsu00 yingsu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zuyu You need to squash the 3 commits together. Otherwise the first commit is going to break CI.

@zuyu zuyu force-pushed the native-decimal-as-double-off branch from 3bc7a47 to dd3e924 Compare November 19, 2024 00:41
@zuyu zuyu requested a review from yingsu00 November 19, 2024 00:42
@zuyu zuyu merged commit 42412f4 into master Nov 19, 2024
60 checks passed
@zuyu zuyu deleted the native-decimal-as-double-off branch November 19, 2024 02:22
yuandagits pushed a commit to yuandagits/presto that referenced this pull request Nov 28, 2024
sumi-mathew pushed a commit to sumi-mathew/presto that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants