Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native] Update README #24056

Merged
merged 2 commits into from
Nov 16, 2024
Merged

[native] Update README #24056

merged 2 commits into from
Nov 16, 2024

Conversation

zuyu
Copy link
Contributor

@zuyu zuyu commented Nov 15, 2024

Change includes proxygen version update per Velox.

presto/presto-native-execution/scripts/setup-macos.sh

Line 27 in 6e87912

github_checkout facebook/proxygen "${FB_OS_VERSION}" 

== NO RELEASE NOTE ==

@zuyu zuyu requested review from steveburnett and a team as code owners November 15, 2024 20:39
@zuyu zuyu requested a review from presto-oss November 15, 2024 20:39
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Nov 15, 2024
steveburnett
steveburnett requested changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc update! One nit, let me know what you think.

@zuyu zuyu requested a review from steveburnett November 15, 2024 22:22
steveburnett
steveburnett approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

@zuyu zuyu merged commit ecfda83 into master Nov 16, 2024
60 checks passed
@zuyu zuyu deleted the native-readme-fix branch November 16, 2024 00:01
yuandagits pushed a commit to yuandagits/presto that referenced this pull request Nov 28, 2024
@zuyu @yuandagits
[native] Update README (prestodb#24056)
2c94799
sumi-mathew pushed a commit to sumi-mathew/presto that referenced this pull request Dec 4, 2024
@zuyu
[native] Update README (prestodb#24056)
4752616
This was referenced Jan 28, 2025
Merged
Closed
This was referenced Mar 7, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveburnett steveburnett steveburnett approved these changes

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

Assignees
No one assigned
Labels
from:IBM PR from IBM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zuyu @steveburnett @prestodb-ci