Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IGNORE] For testing #24034

Closed
wants to merge 1 commit into from
Closed

[IGNORE] For testing #24034

wants to merge 1 commit into from

Conversation

tdcmeehan
Copy link
Contributor

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... :pr:`12345`
* ... :pr:`12345`

Hive Connector Changes
* ... :pr:`12345`
* ... :pr:`12345`

If release note is NOT required, use:

== NO RELEASE NOTE ==

@tdcmeehan tdcmeehan requested review from steveburnett and a team as code owners November 13, 2024 16:29
@tdcmeehan tdcmeehan requested a review from presto-oss November 13, 2024 16:29
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Nov 13, 2024
ethanyzhang
ethanyzhang requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@ethanyzhang ethanyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test request

steveburnett
steveburnett approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (not really)

@zuyu zuyu deleted the tdcmeehan-patch-4 branch November 14, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanyzhang ethanyzhang ethanyzhang approved these changes

@steveburnett steveburnett steveburnett approved these changes

@prestodb-ci prestodb-ci prestodb-ci approved these changes

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

Assignees
No one assigned
Labels
from:IBM PR from IBM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tdcmeehan @ethanyzhang @steveburnett @prestodb-ci