-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CVEs about h2database #24001
Draft
ShahimSharafudeen
wants to merge
10
commits into
prestodb:master
Choose a base branch
from
ShahimSharafudeen:h2database_cve_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix CVEs about h2database #24001
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a442074
Fix CVEs about h2database dependency
ShahimSharafudeen 07d24ed
Upgrad H2database to 1.4.200
ShahimSharafudeen 2a60472
Upgrade the H2db version to 2.2.220 and update the expected query syntax
ShahimSharafudeen 6315d1c
Set non keywords in H2 database 2.x
ShahimSharafudeen fd0a5f7
Update the H2db startdate as after 1890-09-30
ShahimSharafudeen 861fb90
Fix cast null as array syntax error in AbstractTestWindowQueries class
ShahimSharafudeen 4678820
Set non keyword as Value and Key in jdbc url
ShahimSharafudeen 5cd023c
Fix the nested Array and Row syntax change issue
ShahimSharafudeen 248986b
Fix decimal cast syntax error
ShahimSharafudeen 359b804
Fix the nested array and row syntax issue
ShahimSharafudeen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us know if you were able to figure out the root cause of the issue we discussed internally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya I found the issue. H2db version 1.4.200 only support the start date from "1890-09-30". If i am give above that this date then test cases will pass.
Reference link : h2database/h2database#2261
Currently i am trying to upgrade the version as 2.2.220, which has no vulnerabilities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find. :D