-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add javadoc on internal UUID format #23961
Conversation
Discussed with @BryanCutler about this who has been working on the Presto native support. This will be the officially-documented format for now. However, in the future we would like to update our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits, nothing significant. Thanks for the doc.
presto-common/src/main/java/com/facebook/presto/common/type/UuidType.java
Outdated
Show resolved
Hide resolved
presto-common/src/main/java/com/facebook/presto/common/type/UuidType.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ZacBlanco
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ZacBlanco
49550fc
114a130
to
49550fc
Compare
* The value of a UUID is stored as two longs in little-endian | ||
* format in the order of [MSB, LSB] when executing within Presto: | ||
* <br> | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrapping in a <pre> ... </pre>
block might be better
* +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | ||
* | MSB (LE) | LSB (LE) | | ||
* +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* | |
* </pre> |
* The value of a UUID is stored as two longs in little-endian | ||
* format in the order of [MSB, LSB] when executing within Presto: | ||
* <br> | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* | |
* <pre> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the Clarification.
Description
Adds a javadoc for presto-native developers to reference the internal format of UUIDs
Motivation and Context
Helps better specify the format to maintain compatibility
Impact
N/A
Test Plan
N/A
Contributor checklist
Release Notes
If release note is NOT required, use: