[native] Reduce numer of http requests for Exchange #23097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to send an explicit ack when PrestoExchangeSource is active. A subsequent getData request is expected to acknowledge previously received data automatically
To accommodate long pool delay increase in Velox (2s -> 10s). The request timeout has to be higher than the long pool delay to let the remote server properly respond before terminating a connection.
|
Let's try to advance Velox in a separate PR when possible. |
|
My bad! I just noticed it is in a separate commit. This works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce number of HTTP requests issued by exchange protocol
Motivation and Context
With high number of partitions the amount of data exchanged in a single round trip can be quite low (~50kb). This PR reduces number of explicit acknowledge calls as well as increases the long pool delay to avoid sending unnecessary pings when the buffers are empty (for example of not yet active stages).
Impact
Improves cpu efficiency at a fully utilized cluster by ~5%.
Test Plan
CI
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.