Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native] Advance velox version #22471

Merged
merged 1 commit into from
Apr 10, 2024
Merged

[native] Advance velox version #22471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions presto-native-execution/presto_cpp/main/QueryContextManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,6 @@ std::shared_ptr<core::QueryCtx> QueryContextManager::findOrCreateQueryCtx(
!SystemConfig::instance()->memoryArbitratorKind().empty()
? memory::MemoryReclaimer::create()
: nullptr);
RECORD_HISTOGRAM_METRIC_VALUE(
kCounterQueryMemoryPoolInitCapacity, pool->capacity());

auto queryCtx = std::make_shared<core::QueryCtx>(
driverExecutor_,
Expand Down
10 changes: 0 additions & 10 deletions presto-native-execution/presto_cpp/main/common/Counters.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,6 @@ void registerPrestoMetrics() {
0,
62l * 1024 * 1024 * 1024, // max bucket value: 62GB
100);
DEFINE_HISTOGRAM_METRIC(
kCounterQueryMemoryPoolInitCapacity,
4l * 1024 * 1024, // 4MB bucket size
0,
1024l * 1024 * 1024, // 1GB max size
5,
50,
90,
95,
100);

/// ================== AsyncDataCache Counters ==================

Expand Down
3 changes: 0 additions & 3 deletions presto-native-execution/presto_cpp/main/common/Counters.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,6 @@ constexpr folly::StringPiece kCounterMmapRawAllocBytesSmall{
/// Peak number of bytes queued in PrestoExchangeSource waiting for consume.
constexpr folly::StringPiece kCounterExchangeSourcePeakQueuedBytes{
"presto_cpp.exchange_source_peak_queued_bytes"};
/// Initial capacity of the root memory pool of queries
constexpr folly::StringPiece kCounterQueryMemoryPoolInitCapacity{
"presto_cpp.query_memory_pool_init_capacity"};

/// ================== Memory Arbitrator Counters =================

Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/velox
Open in desktop
Submodule velox updated 59 files
+20 −0 velox/common/base/Counters.cpp
+6 −0 velox/common/base/Counters.h
+2 −1 velox/common/hyperloglog/HllUtils.h
+5 −0 velox/common/memory/Memory.cpp
+1 −0 velox/common/memory/Memory.h
+14 −4 velox/common/memory/MemoryPool.cpp
+16 −5 velox/common/memory/MemoryPool.h
+23 −7 velox/common/memory/SharedArbitrator.cpp
+20 −3 velox/common/memory/SharedArbitrator.h
+1 −0 velox/common/memory/tests/MemoryCapExceededTest.cpp
+18 −12 velox/common/memory/tests/MemoryPoolTest.cpp
+52 −66 velox/common/memory/tests/SharedArbitratorTest.cpp
+2 −2 velox/connectors/Connector.h
+1 −1 velox/core/PlanNode.h
+10 −0 velox/docs/monitoring/metrics.rst
+11 −0 velox/docs/monitoring/stats.rst
+13 −7 velox/exec/Driver.cpp
+32 −16 velox/exec/HashProbe.cpp
+9 −3 velox/exec/HashProbe.h
+7 −1 velox/exec/Operator.cpp
+13 −13 velox/exec/Operator.h
+1 −1 velox/exec/PartitionedOutput.cpp
+6 −6 velox/exec/TaskStats.h
+35 −82 velox/exec/tests/AggregationTest.cpp
+1 −0 velox/exec/tests/CMakeLists.txt
+3 −0 velox/exec/tests/DriverTest.cpp
+352 −155 velox/exec/tests/HashJoinTest.cpp
+20 −13 velox/exec/tests/JoinFuzzer.cpp
+11 −0 velox/exec/tests/MultiFragmentTest.cpp
+10 −4 velox/exec/tests/OperatorUtilsTest.cpp
+56 −96 velox/exec/tests/OrderByTest.cpp
+141 −0 velox/exec/tests/PartitionedOutputTest.cpp
+6 −5 velox/exec/tests/SortBufferTest.cpp
+12 −6 velox/exec/tests/SqlTest.cpp
+1 −0 velox/exec/tests/TableWriteTest.cpp
+69 −5 velox/exec/tests/TaskTest.cpp
+7 −0 velox/exec/tests/ValuesTest.cpp
+22 −10 velox/exec/tests/utils/OperatorTestBase.cpp
+5 −1 velox/exec/tests/utils/OperatorTestBase.h
+3 −1 velox/expression/ReverseSignatureBinder.cpp
+15 −2 velox/expression/ReverseSignatureBinder.h
+246 −0 velox/expression/tests/ArgumentTypeFuzzerTest.cpp
+107 −6 velox/expression/tests/utils/ArgumentTypeFuzzer.cpp
+12 −2 velox/expression/tests/utils/ArgumentTypeFuzzer.h
+0 −1 velox/functions/prestosql/CMakeLists.txt
+1 −0 velox/functions/prestosql/DecimalFunctions.cpp
+0 −207 velox/functions/prestosql/GreatestLeast.cpp
+101 −0 velox/functions/prestosql/GreatestLeast.h
+1 −1 velox/functions/prestosql/HyperLogLogFunctions.h
+1 −1 velox/functions/prestosql/Map.cpp
+29 −12 velox/functions/prestosql/aggregates/ApproxDistinctAggregate.cpp
+63 −22 velox/functions/prestosql/aggregates/tests/ApproxDistinctTest.cpp
+1 −0 velox/functions/prestosql/aggregates/tests/ApproxPercentileTest.cpp
+6 −0 velox/functions/prestosql/aggregates/tests/MinMaxByAggregationTest.cpp
+2 −1 velox/functions/prestosql/fuzzer/WindowFuzzerTest.cpp
+28 −4 velox/functions/prestosql/registration/GeneralFunctionsRegistration.cpp
+8 −0 velox/functions/prestosql/tests/DecimalArithmeticTest.cpp
+46 −23 velox/functions/prestosql/tests/GreatestLeastTest.cpp
+17 −0 velox/functions/prestosql/tests/MapTest.cpp
Loading