Fix memory revoke in TopNRowNumberOperator
#22281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #22127 .
TopNRowNumberOperator
should not simply return a completed future forstartMemoryRevoke()
when it's flagfinishing
is true. That could lead in the problem described in #22127 when events occur in following order:finish()
method is called by upstream operator, and the flagmemoryRevokingRequested
is set byMemoryRevokingScheduler
.handleMemoryRevoke()
, the error above would appear.Test Plan
TestDistributedSpilledQueriesWithTempStorage.testRowNumberLimit
Contributor checklist
Release Notes